Fix #387: Fix git clone auth by honoring configured git account username#1448
Open
lukababu wants to merge 1 commit into
Open
Fix #387: Fix git clone auth by honoring configured git account username#1448lukababu wants to merge 1 commit into
lukababu wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #387
Why
Private repo clones can fail on providers that validate HTTP basic-auth usernames (for example GitLab deploy tokens, Bitbucket, and GitHub fine-grained PATs).
Komodo currently resolves a token but loses the configured account username before URL construction, so clone URLs fall back to
token:<token>@.... That causesHTTP Basic: Access deniedfor providers that require a specific username.What changed
username:tokenform (while preserving existingtokenvalues that already contain:for backward compatibility).Behavior
Before:
https://token:<token>@<provider>/<repo>After:
https://<configured-username>:<token>@<provider>/<repo>Backward compatibility
tokenfield manually set tousername:token) continue to work unchanged.Validation
cargo check -p komodo_corepassescargo check -p komodo_peripherypassescargo clippy -p komodo_core -p komodo_periphery --no-depspasses