Skip to content

fix(monad): keep blob header fields on MONAD_EIGHT #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
haythemsellami wants to merge 1 commit into
base: forks/monad_nine
Choose a base branch
from
+4 −25
Open

fix(monad): keep blob header fields on MONAD_EIGHT #21

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 0 additions & 21 deletions packages/testing/src/execution_testing/forks/forks/forks.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3272,27 +3272,6 @@ def blob_base_cost(
class MONAD_EIGHT(Prague, solc_name="cancun"): # noqa: N801
"""MONAD_EIGHT fork."""

@classmethod
def header_excess_blob_gas_required(
cls, *, block_number: int = 0, timestamp: int = 0
) -> bool:
"""
MONAD_EIGHT does not include blob header fields.

Monad keeps the point-evaluation precompile but does not support blob
transactions or blob gas accounting.
"""
del block_number, timestamp
return False

@classmethod
def header_blob_gas_used_required(
cls, *, block_number: int = 0, timestamp: int = 0
) -> bool:
"""MONAD_EIGHT does not include blob header fields."""
del block_number, timestamp
return False

@classmethod
def supports_blobs(
cls, *, block_number: int = 0, timestamp: int = 0
Expand Down
8 changes: 4 additions & 4 deletions packages/testing/src/execution_testing/forks/tests/test_forks.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -396,11 +396,11 @@ def test_tx_types() -> None: # noqa: D103
Cancun.tx_types() == list(range(4)) # noqa: B015


def test_monad_eight_disables_blob_support() -> None:
"""MONAD_EIGHT keeps the KZG precompile but does not support blob txs."""
def test_monad_eight_disables_blob_transactions_not_headers() -> None:
"""MONAD_EIGHT keeps blob header fields but rejects blob tx behavior."""
assert MONAD_EIGHT.supports_blobs() is False
assert MONAD_EIGHT.header_excess_blob_gas_required() is False
assert MONAD_EIGHT.header_blob_gas_used_required() is False
assert MONAD_EIGHT.header_excess_blob_gas_required() is True
assert MONAD_EIGHT.header_blob_gas_used_required() is True
assert MONAD_EIGHT.blob_schedule() is None
assert MONAD_EIGHT.engine_get_blobs_version() is None
assert MONAD_EIGHT.engine_new_payload_blob_hashes() is False
Expand Down
Loading