Open
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 7392f050fb
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Production lightning nodes were getting OOM-killed during boot. The bun process running the NAPI-RS native addon hit 857MB RSS in a 1GB container, leaving no headroom for channel monitor deserialization at startup. glibc's malloc fragments heavily under Rust's allocation patterns (many small, short-lived allocations interleaved with long-lived ones), inflating RSS 30-50% beyond actual usage. jemalloc's arena-based allocator and thread-local caching avoid this fragmentation. disable_initial_exec_tls is required because NAPI-RS addons are loaded via dlopen at runtime. Without it, jemalloc's TLS usage exhausts the static TLS block allocated at program start, since dlopen'd libraries get a smaller TLS allocation than statically linked ones.
7392f05 to
75daa6b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Production lightning nodes were getting OOM-killed during boot. The bun process running the NAPI-RS native addon hit 857MB RSS in a 1GB container, leaving no headroom for channel monitor deserialization at startup.
glibc's malloc fragments heavily under Rust's allocation patterns (many small, short-lived allocations interleaved with long-lived ones), inflating RSS 30-50% beyond actual usage. jemalloc's arena-based allocator and thread-local caching avoid this fragmentation.
disable_initial_exec_tls is required because NAPI-RS addons are loaded via dlopen at runtime. Without it, jemalloc's TLS usage exhausts the static TLS block allocated at program start, since dlopen'd libraries get a smaller TLS allocation than statically linked ones.