CSHARP-5846: Global GuidSerializer settings ignored for object-typed properties#1990
Open
papafe wants to merge 5 commits into
Open
CSHARP-5846: Global GuidSerializer settings ignored for object-typed properties#1990papafe wants to merge 5 commits into
papafe wants to merge 5 commits into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates ObjectSerializer so that when constructed with GuidRepresentation.Unspecified, it will use the globally registered Guid serializer (instead of always creating its own GuidSerializer(Unspecified)), addressing CSHARP-5846 (“global GuidSerializer settings ignored for object-typed properties”). Adds regression tests validating serialization and deserialization behavior using a temporarily substituted global GuidSerializer.
Changes:
ObjectSerializernow resolves_guidSerializerfromBsonSerializer.LookupSerializer<Guid>()whenguidRepresentationisUnspecified.- Added tests ensuring object-typed Guid values use the globally registered Guid serializer for UUID legacy representation.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
src/MongoDB.Bson/Serialization/Serializers/ObjectSerializer.cs |
Uses the globally registered Guid serializer when guidRepresentation is Unspecified. |
tests/MongoDB.Bson.Tests/Serialization/Serializers/ObjectSerializerTests.cs |
Adds regression tests covering global Guid serializer usage for object-typed Guid serialization/deserialization. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+147
to
+157
| var registeredSerializer = BsonSerializer.LookupSerializer<Guid>(); | ||
| if (registeredSerializer is GuidSerializer guidSerializer) | ||
| { | ||
| _guidSerializer = guidSerializer; | ||
| _guidRepresentation = guidSerializer.GuidRepresentation; | ||
| } | ||
| else | ||
| { | ||
| _guidRepresentation = GuidRepresentation.Unspecified; | ||
| _guidSerializer = registeredSerializer; | ||
| } |
papafe
commented
May 7, 2026
| result.Should().Be(guid); | ||
| } | ||
|
|
||
| private static ObjectSerializer CreateObjectSerializerWithRegisteredGuidSerializer( |
Contributor
Author
There was a problem hiding this comment.
I'm curious about what the team thinks about this. Unfortunately without having a local serialization registry, we can't test this properly otherwise.
Comment on lines
+147
to
+157
| var registeredSerializer = BsonSerializer.LookupSerializer<Guid>(); | ||
| if (registeredSerializer is GuidSerializer guidSerializer && guidSerializer.GuidRepresentation != GuidRepresentation.Unspecified) | ||
| { | ||
| _guidSerializer = guidSerializer; | ||
| _guidRepresentation = guidSerializer.GuidRepresentation; | ||
| } | ||
| else | ||
| { | ||
| _guidRepresentation = GuidRepresentation.Unspecified; | ||
| _guidSerializer = new GuidSerializer(GuidRepresentation.Unspecified); | ||
| } |
Comment on lines
+150
to
+152
| if (registered is GuidSerializer gs && gs.GuidRepresentation != GuidRepresentation.Unspecified) | ||
| { | ||
| return gs; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.