Skip to content

impr(quotes): add two English quotes (@RedPandaGuy1234) - #8291

Open
RedPandaGuy1234 wants to merge 7 commits into
monkeytypegame:masterfrom
RedPandaGuy1234:master
Open

impr(quotes): add two English quotes (@RedPandaGuy1234)#8291
RedPandaGuy1234 wants to merge 7 commits into
monkeytypegame:masterfrom
RedPandaGuy1234:master

Conversation

@RedPandaGuy1234

@RedPandaGuy1234 RedPandaGuy1234 commented Jul 27, 2026

Copy link
Copy Markdown

This was originally in #8284, but was now fixed. This adds one new English quote from Harry Potter and the Deathly Hallows and fixes a formatting error.

@monkeytypegeorge monkeytypegeorge added frontend User interface or web stuff assets Languages, themes, layouts, etc. labels Jul 27, 2026
@RedPandaGuy1234

RedPandaGuy1234 commented Jul 27, 2026

Copy link
Copy Markdown
Author

I had to add the second commit changing the workflow file because the --check flag was still in the check-formatting.yml file, and the "check formatting" check would fail without deleting it.

@RedPandaGuy1234 RedPandaGuy1234 changed the title impr(quotes): add an English quote (@RedPandaGuy1234) impr(quotes): add an English quote and fix a workflow file error (@RedPandaGuy1234) Jul 27, 2026
This was just added to run the checks on monkeytypegame#8291 again.
@github-actions

Copy link
Copy Markdown
Contributor

Continuous integration check(s) failed. Please review the failing check's logs and make the necessary changes.

@github-actions github-actions Bot added the waiting for update Pull requests or issues that require changes/comments before continuing label Jul 27, 2026
After the extra line was added, a different error occurred, so I deleted it.
@github-actions github-actions Bot removed the waiting for update Pull requests or issues that require changes/comments before continuing label Jul 27, 2026
Comment thread .github/workflows/check-formatting.yml Outdated
This quote is from The Hunger Games.
@RedPandaGuy1234 RedPandaGuy1234 changed the title impr(quotes): add an English quote and fix a workflow file error (@RedPandaGuy1234) impr(quotes): add two English quotes and fix a workflow file error (@RedPandaGuy1234) Jul 27, 2026
@fehmer fehmer added the format Ask the bot to fix formatting on this pr label Jul 27, 2026
Comment thread .github/workflows/check-formatting.yml
@RedPandaGuy1234

Copy link
Copy Markdown
Author

This works! Could you approve it, so it can be merged @fehmer?

@fehmer

fehmer commented Jul 27, 2026

Copy link
Copy Markdown
Member

hi, mio approves/merges the pr.

@RedPandaGuy1234

Copy link
Copy Markdown
Author

hi, mio approves/merges the pr.

Oh, okay. Thank you for helping me with this!

@RedPandaGuy1234

Copy link
Copy Markdown
Author

The commit you added @fehmer fixed the recurring error that I had with my quotes.

@fehmer fehmer changed the title impr(quotes): add two English quotes and fix a workflow file error (@RedPandaGuy1234) impr(quotes): add two English quotes (@RedPandaGuy1234) Jul 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

assets Languages, themes, layouts, etc. format Ask the bot to fix formatting on this pr frontend User interface or web stuff

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants