moq-lite-05: add Frame Start to FETCH#1595
Merged
Merged
Conversation
Implements moq-dev/drafts#24. Adds a Frame Start field to the FETCH message: the 0-based index of the first frame to return, letting a subscriber resume partway through a group instead of always starting at frame 0. A value of 0 returns the entire group. Gated on moq-lite-05-wip; lite-03/lite-04 omit the field and default it to 0. Wire-only addition, since FETCH is not yet plumbed into a live serving flow. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Implements moq-dev/drafts#24. Adds a
Frame Startfield to the moq-liteFETCHmessage in both the Rust (rs/moq-net) and JS (js/net) implementations.Why
Today a FETCH always returns a group from frame
0.Frame Startis the 0-based index of the first frame to return; the publisher skips all earlier frames, letting a subscriber resume partway through a partially-received group.0returns the entire group.Details
rs/moq-net/src/lite/fetch.rs): addedframe_start: u64toFetch, encoded/decoded only onLite05Wip+. Lite03/Lite04 omit it and default to0, following the existing version-gating convention (older drafts listed explicitly, newest as the_fallthrough).js/net/src/lite/fetch.ts): addedframeStart(default0) with matching version-gated encode/decode; threadedversioninto the private encode/decode helpers.Scope notes
Start Group/End Group→Group Start/Group Endrename also in drafts#24 is, per its own changelog entry, wire format unchanged (spec prose only). The implementations already match the wire, so internal field names were left as-is to avoid a large, behavior-neutral churn across publicmoq-netAPIs and downstream consumers.FETCHis currently a wire definition only; it is not yet plumbed into a live serving flow, so there is no publisher-side skip/wait behavior to implement here. The field is in place for when that flow lands.Test plan
cargo test -p moq-net lite::fetchbun test js/net/src/lite/fetch.test.tscargo fmt --check+ Biome cleanTargets
devper the branch-targeting guidance (wire-protocol change underrs/moq-net).🤖 Generated with Claude Code
(Written by Claude)