Skip to content

revert(hang): keep captions on dev - #2571

Merged
kixelated merged 1 commit into
mainfrom
codex/revert-captions-main
Jul 30, 2026
Merged

revert(hang): keep captions on dev#2571
kixelated merged 1 commit into
mainfrom
codex/revert-captions-main

Conversation

@kixelated

Copy link
Copy Markdown
Collaborator

Summary

The caption change added a public field to an externally constructible struct. Existing downstream struct literals would stop compiling, so the feature belongs on dev under the repository's branch-targeting policy. Once this revert lands, release-plz can regenerate #2562 without the moq-mux major bump and caption-driven downstream releases.

Public API changes

  • removes the unreleased Catalog::text field and caption catalog types from main
  • restores the latest published moq-mux catalog construction surface on main

Test plan

  • just fix
  • just check

(Written by GPT-5)

The caption catalog field breaks external Catalog struct literals, so remove the feature from main while retaining it on dev.

Co-Authored-By: GPT-5 <noreply@openai.com>
@kixelated
kixelated marked this pull request as ready for review July 30, 2026 23:29

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry @kixelated, you have reached your weekly rate limit of 500000 diff characters.

Please try again later or upgrade to continue using Sourcery

@kixelated
kixelated enabled auto-merge (squash) July 30, 2026 23:29
@kixelated
kixelated disabled auto-merge July 30, 2026 23:29
@kixelated
kixelated enabled auto-merge (squash) July 30, 2026 23:29
@kixelated
kixelated merged commit 3656444 into main Jul 30, 2026
3 checks passed
@kixelated
kixelated deleted the codex/revert-captions-main branch July 30, 2026 23:39
@coderabbitai

coderabbitai Bot commented Jul 30, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 270e4faa-baf4-4628-8bac-6d08cb8a2ec9

📥 Commits

Reviewing files that changed from the base of the PR and between 5fd923f and a40c3e2.

⛔ Files ignored due to path filters (2)
  • bun.lock is excluded by !**/*.lock
  • js/watch/src/ui/icons/captions.svg is excluded by !**/*.svg
📒 Files selected for processing (34)
  • doc/bin/cli.md
  • doc/bin/gstreamer.md
  • doc/concept/layer/hang.md
  • drafts/draft-lcurley-moq-hang.md
  • js/hang/src/catalog/index.ts
  • js/hang/src/catalog/priority.ts
  • js/hang/src/catalog/root.ts
  • js/hang/src/catalog/text.ts
  • js/publish/src/broadcast.ts
  • js/publish/src/rendition.ts
  • js/watch/package.json
  • js/watch/src/element.ts
  • js/watch/src/index.ts
  • js/watch/src/text/index.ts
  • js/watch/src/text/renderer.test.ts
  • js/watch/src/text/renderer.ts
  • js/watch/src/text/source.ts
  • js/watch/src/ui/components/captions-button.ts
  • js/watch/src/ui/components/captions.ts
  • js/watch/src/ui/components/control-bar.ts
  • js/watch/src/ui/components/settings-panel.ts
  • js/watch/src/ui/icons.ts
  • js/watch/src/ui/state.ts
  • rs/hang/src/catalog/mod.rs
  • rs/hang/src/catalog/priority.rs
  • rs/hang/src/catalog/root.rs
  • rs/hang/src/catalog/text/format.rs
  • rs/hang/src/catalog/text/mod.rs
  • rs/moq-gst/src/sink/imp.rs
  • rs/moq-gst/src/sink/pad.rs
  • rs/moq-mux/src/catalog/consumer.rs
  • rs/moq-mux/src/catalog/hang/ext.rs
  • rs/moq-mux/src/catalog/mod.rs
  • rs/moq-mux/src/catalog/tracks.rs

Walkthrough

Removed text-track support across the catalog specification and implementations. JavaScript and Rust catalog APIs no longer define text sections, priorities, or rendition types. Publishing, muxing, and GStreamer paths now process only audio and video. Watch caption sources, renderers, controls, settings, icons, exports, tests, and dependency were removed. Related CLI, GStreamer, conceptual, and specification documentation was updated.

✨ Finishing Touches
✨ Simplify code
  • Create PR with simplified code
  • Commit simplified code in branch codex/revert-captions-main

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant