revert(hang): keep captions on dev - #2571
Conversation
The caption catalog field breaks external Catalog struct literals, so remove the feature from main while retaining it on dev. Co-Authored-By: GPT-5 <noreply@openai.com>
There was a problem hiding this comment.
Sorry @kixelated, you have reached your weekly rate limit of 500000 diff characters.
Please try again later or upgrade to continue using Sourcery
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (2)
📒 Files selected for processing (34)
WalkthroughRemoved text-track support across the catalog specification and implementations. JavaScript and Rust catalog APIs no longer define text sections, priorities, or rendition types. Publishing, muxing, and GStreamer paths now process only audio and video. Watch caption sources, renderers, controls, settings, icons, exports, tests, and dependency were removed. Related CLI, GStreamer, conceptual, and specification documentation was updated. ✨ Finishing Touches✨ Simplify code
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary
mainmoq_mux::catalog::hang::Catalog::textfield before releasedev, where published API breaks are stagedThe caption change added a public field to an externally constructible struct. Existing downstream struct literals would stop compiling, so the feature belongs on
devunder the repository's branch-targeting policy. Once this revert lands, release-plz can regenerate #2562 without themoq-muxmajor bump and caption-driven downstream releases.Public API changes
Catalog::textfield and caption catalog types frommainmoq-muxcatalog construction surface onmainTest plan
just fixjust check(Written by GPT-5)