Updates reg.arginfo to make direct use of inspect.signature#68
Open
Daverball wants to merge 1 commit into
Open
Updates reg.arginfo to make direct use of inspect.signature#68Daverball wants to merge 1 commit into
reg.arginfo to make direct use of inspect.signature#68Daverball wants to merge 1 commit into
Conversation
This also updates the supported python versions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #67
In the future we probably should consider getting rid of
reg.arginfoin favor ofinspect.signatureand properly support signatures with positional only and keyword only parameters inreg, but this should be good enough as a backwards-compatible implementation for now, that better supports Python 3.14+. Although there are some open questions around performance, so we may still want to provide a simple wrapper.I decided to get rid of the internal
get_callable_infohelper, since the info we need forinspect.signatureis different enough, that keeping the function around, would have been confusing for anyone, that for whatever reason tried to rely on this internal helper. So it seemed better to inline the new logic intoarginfo.