test: add \\r carriage return expansion tests for parse#978
Closed
mahmoodhamdi wants to merge 1 commit intomotdotla:masterfrom
Closed
test: add \\r carriage return expansion tests for parse#978mahmoodhamdi wants to merge 1 commit intomotdotla:masterfrom
mahmoodhamdi wants to merge 1 commit intomotdotla:masterfrom
Conversation
Add tests verifying that \\r is expanded to actual carriage return only in double-quoted values, matching the existing \\n expansion behavior.
Contributor
Author
|
Closing this — I should have consolidated these into a single well-structured PR instead of opening them individually. Apologies for the noise. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
\ris expanded to carriage return in double-quoted values\ris NOT expanded in unquoted values\ris NOT expanded in single-quoted valuesThe parser expands both
\nand\rin double-quoted values (lines 76-77 of main.js), but only\nexpansion had test coverage.Test plan
npm testpasses (197 tests)