Skip to content

Fix DisplaySolution::fillMessage() drops info and execution_info from SubTrajectory messages#749

Merged
rhaschke merged 2 commits into
moveit:ros2from
lunarifish:bugfix260531
Jun 9, 2026
Merged

Fix DisplaySolution::fillMessage() drops info and execution_info from SubTrajectory messages#749
rhaschke merged 2 commits into
moveit:ros2from
lunarifish:bugfix260531

Conversation

@lunarifish

@lunarifish lunarifish commented Jun 6, 2026

Copy link
Copy Markdown

When clicking the "Execute solution" button on the Motion Planning Tasks panel, the action goal sent to the execute_task_solution action server was missing the SolutionInfo and TrajectoryExecutionInfo fields in every SubTrajectory.

The internal DisplaySolution::Data struct had no info_ or execution_info_ fields. Consequently, DisplaySolutionfillMessage() had nothing to write back for SubTrajectory::info and SubTrajectory::execution_info, so they were always sent as empty values.

Any action server that relies on execution_info.controller_names or other SolutionInfo fields like markers, planner_id, cost, id would receive empty data. I happened to hit this because my action server uses execution_info, and I triggered it through the panel button.

@rhaschke rhaschke left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I deliberately chose to drop the SolutionInfo to reduce the memory footprint.
However, I agree to store the ExecutionInfo as this is obviously required for execution.
All other fields (like markers) are not required for solution execution.

@lunarifish

Copy link
Copy Markdown
Author

Okay! I have removed SolutionInfo from the Data struct.

@rhaschke rhaschke merged commit f16c557 into moveit:ros2 Jun 9, 2026
2 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants