Fix DisplaySolution::fillMessage() drops info and execution_info from SubTrajectory messages#749
Merged
Merged
Conversation
…sks panel is missing execution info
rhaschke
reviewed
Jun 8, 2026
rhaschke
left a comment
Contributor
There was a problem hiding this comment.
I deliberately chose to drop the SolutionInfo to reduce the memory footprint.
However, I agree to store the ExecutionInfo as this is obviously required for execution.
All other fields (like markers) are not required for solution execution.
Author
|
Okay! I have removed |
rhaschke
approved these changes
Jun 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When clicking the "Execute solution" button on the Motion Planning Tasks panel, the action goal sent to the
execute_task_solutionaction server was missing theSolutionInfoandTrajectoryExecutionInfofields in everySubTrajectory.The internal
DisplaySolution::Datastruct had no info_ or execution_info_ fields. Consequently,DisplaySolutionfillMessage()had nothing to write back forSubTrajectory::infoandSubTrajectory::execution_info, so they were always sent as empty values.Any action server that relies on
execution_info.controller_namesor otherSolutionInfofields likemarkers,planner_id,cost,idwould receive empty data. I happened to hit this because my action server usesexecution_info, and I triggered it through the panel button.