Add new algorithm identifiers and relax AuthenticatorInfo algorithms parsing#359
Merged
Merged
Conversation
jschanck
force-pushed
the
new-algorithm-ids
branch
from
b328907 to
5f2c50e
Compare
mozkeeler
approved these changes
Jun 3, 2026
jschanck
force-pushed
the
new-algorithm-ids
branch
from
5f2c50e to
a50688c
Compare
mxinden
reviewed
Jun 8, 2026
| openssl-sys = { version = "0.9", optional = true} | ||
| openssl = { version = "0.10", optional = true} | ||
| nss-rs = { git = "https://github.com/mozilla/nss-rs", version = "^0.12", optional = true } | ||
| nss-rs = { git = "https://github.com/mozilla/nss-rs", version = ">=0.12", optional = true } |
Member
There was a problem hiding this comment.
This disables all semver safety guards for future nss-rs versions, effectively saying that authenticator-rs is compatible with all future nss-rs versions, no matter what breaking changes nss-rs introduces.
Given that we (Mozilla) control both authenticator-rs and nss-rs, that might be fine, though it doesn't prevent human error on our end.
I would recommend:
nss-rs = { git = "https://github.com/mozilla/nss-rs", version = ">=0.12, <= 0.13", optional = true }
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #356