Skip to content

Fix #708 - Open PayPal inside the Facebook when donating#755

Open
maxxcrawford wants to merge 1 commit into
mainfrom
708-facebook-donate-paypal
Open

Fix #708 - Open PayPal inside the Facebook when donating#755
maxxcrawford wants to merge 1 commit into
mainfrom
708-facebook-donate-paypal

Conversation

@maxxcrawford
Copy link
Copy Markdown
Collaborator

Summary

This patch adds logic to open up a PayPal window inside the Facebook Container if the origin URL is https://facebook.com/donate and allows PayPal resources to be loaded inside Facebook Container.

Privacy Considerations:

  • Does this patch leak info for users who have both PayPal and Facebook accounts but do not connect services?
  • Current allowed resources from PayPal include a wild card for subdomains. Is that okay?

Testing Steps

  • Log into Facebook
    • Note - Make sure you do not have PayPal already connected as a funding source
  • Go to https://www.facebook.com/fundraisers/ and select any active campaign
  • Click "Donate" button
  • Under the Payment Method section, select "Connect to PayPal"
  • Click blue "Donate" button at the bottom of the form
  • EXPECTED: A separate PayPal window should open and be INSIDE the Facebook Container

@maxxcrawford maxxcrawford linked an issue Apr 22, 2021 that may be closed by this pull request
@maxxcrawford maxxcrawford force-pushed the 708-facebook-donate-paypal branch from f6e0802 to 88994e1 Compare May 6, 2021 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Cant donate with PayPal when Facebook Container installed

1 participant