Bug 2034605 - Switch to an SQLite storage backend#3405

Draft

badboy wants to merge 30 commits into

mainfrom

sqlite-2026-approach

Commits on Apr 24, 2026

Import sqlite storage as separate module
badboy
committed
Rust dependency: Add `rusqlite`
badboy
committed
Vetting newly imported crates
badboy
committed
Use the sqlite module as the database layer
badboy
committed
Serialize values using MessagePack instead of bincode
badboy
committed
Implement the label verifier against sqlite storage
badboy
committed
Correctly assemble payload for labeled metrics
badboy
committed
Simplify getting metrics out again
badboy
committed
sqlite: Implement clearing of lifetime storage
badboy
committed
sqlite: Measure database on-disk size by scanning the directory
badboy
committed
Handle static labels like dynamic ones: stored along with the metric
badboy
committed
Copy over is_ping_enabled check instead of is_upload_enabled
badboy
committed
Rework how dynamic labels are validated
badboy
committed
Correctly validate usage of key-only/category-only dual-labels
badboy
committed
Remove now-unused database code
badboy
committed
Switch to get_metric everywhere
badboy
committed
Return a specific LabelCheck that knows how to report an error at a later point
badboy
committed
Remove strip_label usage now that labels are stored separately
badboy
committed
Implement get_identifiers based on the new label storage.
badboy
committed
sqlite: Set synchronous=NORMAL to sync less often, but at the critical moments
badboy
committed
Rename to `MetricLabel` now that it's always used to store the label
badboy
committed
Implement rkv->sqlite migration
badboy
committed
Re-enable client_id tests
badboy
committed
Handle error recording in a single place again
badboy
committed
Test: ensure we don't record errors if we aren't enabled
badboy
committed
Handle sqlite load errors
badboy
committed
Test several sqlite edge cases
badboy
committed
Test what happens if database is otherwise locked
badboy
committed
Handle possible SQLite query errors and bubble them up instead of blindly panicking
badboy
committed
A test to verify that all metrics are properly migrated.
badboy
committed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Bug 2034605 - Switch to an SQLite storage backend#3405

Bug 2034605 - Switch to an SQLite storage backend#3405
badboy wants to merge 30 commits into
mainfrom
sqlite-2026-approach

Commits on Apr 24, 2026

Import sqlite storage as separate module

Rust dependency: Add `rusqlite`

Vetting newly imported crates

Use the sqlite module as the database layer

Serialize values using MessagePack instead of bincode

Implement the label verifier against sqlite storage

Correctly assemble payload for labeled metrics

Simplify getting metrics out again

sqlite: Implement clearing of lifetime storage

sqlite: Measure database on-disk size by scanning the directory

Handle static labels like dynamic ones: stored along with the metric

Copy over is_ping_enabled check instead of is_upload_enabled

Rework how dynamic labels are validated

Correctly validate usage of key-only/category-only dual-labels

Remove now-unused database code

Switch to get_metric everywhere

Return a specific LabelCheck that knows how to report an error at a later point

Remove strip_label usage now that labels are stored separately

Implement get_identifiers based on the new label storage.

sqlite: Set synchronous=NORMAL to sync less often, but at the critical moments

Rename to `MetricLabel` now that it's always used to store the label

Implement rkv->sqlite migration

Re-enable client_id tests

Handle error recording in a single place again

Test: ensure we don't record errors if we aren't enabled

Handle sqlite load errors

Test several sqlite edge cases

Test what happens if database is otherwise locked

Handle possible SQLite query errors and bubble them up instead of blindly panicking

A test to verify that all metrics are properly migrated.