Translate: show where linked strings live when active filters don't match by ayshushus · Pull Request #4281 · mozilla/pontoon

ayshushus · 2026-07-03T17:32:09Z

The string URL param permalinks a specific string, but shared links also carry the filters active at link time (status=missing, search, ...). When the target doesn't match those filters (e.g. link says status=missing but the string is now translated), we silently redirected to the first list entry + a toast, landing users on an unrelated string. Now surface where the string actually lives and let the user choose.

Backend:

base.views._get_paginated_entities: when the requested entity is filtered out, run a second, filter-free lookup gated only by viewability (obsolete=False, translatedresources__locale, project not disabled/system, Project.objects.visible_for(user)) and attach requested_entity_location ({pk, project slug, resource path}) to the response. Absent when the string is invalid/obsolete/not viewable, so behavior is unchanged there. Thread user through for the visibility gate.

State:

api/entity.ts: add RequestedEntityLocation type, optional requested_entity_location on the response.
entities/actions.ts, reducer.ts: carry it onto RECEIVE_ENTITIES, store as requestedEntityLocation. Preserve across pages (backend only reports on page 1), clear on RESET.
entities/hooks.ts: useEntityNotFound() → show when entity > 0 && requestedEntityLocation != null && !found.

UI:

entities/components/StringNotFound.{tsx,css}: new editor-panel screen. "See string" → push({ ...emptyParams, project, resource, entity }) (keep string, drop filters; navigates cross-project). "See other strings" → push({ entity: 0 }) (keep filters, drop string).
App.tsx: render <StringNotFound> over <Entity>/<BatchActions> when useEntityNotFound().show.
entitieslist/EntitiesList.tsx: skip the "select first entity" redirect + ENTITY_NOT_FOUND toast when the string-not-found screen applies.
context/Location.tsx: export emptyParams (consumed by StringNotFound).
locale/en-US/translate.ftl: add entities-StringNotFound--* strings.

Tests:

test_entities_not_matching_string_reports_location: reports location when filtered out; absent when the string matches.
StringNotFound.test.jsx: both navigation paths (incl. cross-project) + null-location renders nothing.

ayshushus · 2026-07-03T19:19:29Z

TODO

We should file follow-up issues to:

Inform users when non-string URL parameters are ignored.
Show the regular 404 page when the resource in the path doesn't exist.

eemeli

Looks decent, though I only did a surface-level review pass here.

eemeli · 2026-07-07T17:31:16Z

+            {`String ${string} is in ${stringResource} (${stringProject}). ` +
+              (filters
+                ? `You're browsing ${queryLabel}, filtered by ${filters}.`
+                : `You're browsing ${queryLabel}.`)}


We should really be able to rely on our own localization system, rather than duplicating the English strings all over the place.

Agreed. Had a meeting with Flod. Changed.

The code still duplicates the English messages in source as well as FTL.

Had quite the time wrapping my head around this, let me know if anything's still off, sorry for the back and forth here.

Co-authored-by: Eemeli Aro <eemeli@gmail.com>

ayshushus · 2026-07-14T16:15:14Z

Attached are some screenshots of typical pages this PR would create. Along with their conditions. This is the string used in testing for the search functionality.

When the string is in a different project, in the same locale.

When the string is in the same project, but doesn't match the current filters.

When the string is in a different locale, we default to the "can't load specified string" notification. Note that this notification lasts for a couple of seconds.

We now:

Reuse existing translations.
Have no fluent variants.
Joining the lists use the UI language.
FTL carries comments explaining variables.
The pre-joined list is explicitly considered.

Co-authored-by: Francesco Lodolo <flod@lodolo.net>

eemeli

Mostly nitpicks left; overall looks good. See also reply on an unresolved previous comment.

… strings

flodolo · 2026-07-24T09:17:22Z

+## on screen. One description per case: hidden by filters, or living in another
+## resource, project, or outside all open projects.
+
+entities-StringNotFound--description-filtered = String { $stringId } is in { $stringResource } ({ $stringProject }), but it doesn’t match your current filters.


We should try to differentiate at least some part of the string from the rest of the text. Can we rap the string ID and resources in a span and style them differently?

flodolo · 2026-07-24T09:21:40Z

+        ),
+    }
+    if requested_entity_location is not None:
+        response["requested_entity"] = requested_entity_location


Why are we passing a location in a field called requested_entity?

flodolo

This looks broken

flodolo · 2026-07-24T09:27:17Z

+## on screen. One description per case: hidden by filters, or living in another
+## resource, project, or outside all open projects.
+
+entities-StringNotFound--description-filtered = String { $stringId } is in { $stringResource } ({ $stringProject }), but it doesn’t match your current filters.


Suggested change

entities-StringNotFound--description-filtered = String { $stringId } is in { $stringResource } ({ $stringProject }), but it doesn’t match your current filters.

entities-StringNotFound--description-filtered = String with internal ID <id>{ $stringId }</id> is in <id>{ $stringResource }</id> (project <project>{ $stringProject }</project>), but it doesn’t match your current filters.

Similar edits would apply to other strings. Right now it doesn't feel very readable.

flodolo · 2026-07-24T09:28:15Z

+entities-StringNotFound--go-to-string = See string { $stringId } in { $stringResource }
+entities-StringNotFound--go-to-string-hint = Search for the requested string, reset current filters.
+
+entities-StringNotFound--show-matching = See other strings in { $queryLabel }


Can we show the name and not the slug of the project in these strings?

Co-authored-by: Francesco Lodolo <flod@lodolo.net>

ayshushus added 3 commits July 3, 2026 13:28

report out-of-query string location

3851e2e

lint fix

98f03ff

thread requested entity location

db384e8

ayshushus self-assigned this Jul 3, 2026

add "string not found" screen

bbb9148

ayshushus requested a review from eemeli July 3, 2026 18:03

ayshushus marked this pull request as ready for review July 3, 2026 18:03

ayshushus requested review from eemeli and functionzz and removed request for eemeli July 7, 2026 13:16

eemeli reviewed Jul 7, 2026

View reviewed changes

flodolo reviewed Jul 7, 2026

View reviewed changes

Comment thread translate/public/locale/en-US/translate.ftl Outdated

ayshushus added 2 commits July 14, 2026 00:37

rename get-entities response field to requested_entity

596a4bb

gate string-not-found on single entity match

08cdae6

eemeli reviewed Jul 14, 2026

View reviewed changes

Comment thread translate/src/modules/entities/hooks.ts Outdated

ayshushus and others added 2 commits July 14, 2026 11:52

update strings and display logic by using pretranslations for filters

ba06f5c

Update translate/src/modules/entities/hooks.ts

3890134

Co-authored-by: Eemeli Aro <eemeli@gmail.com>

flodolo reviewed Jul 21, 2026

View reviewed changes

Comment thread translate/public/locale/en-US/translate.ftl Outdated

Comment thread translate/public/locale/en-US/translate.ftl Outdated

Comment thread translate/public/locale/en-US/translate.ftl Outdated

ayshushus and others added 3 commits July 21, 2026 15:13

Update translate/public/locale/en-US/translate.ftl

cb2957a

Co-authored-by: Francesco Lodolo <flod@lodolo.net>

Update translate/public/locale/en-US/translate.ftl

e5461f0

Co-authored-by: Francesco Lodolo <flod@lodolo.net>

Remove listing features

f4005e1

ayshushus requested review from eemeli and mathjazz July 22, 2026 14:15

remove hasActiveFilters, add filteredOut check

b02d820

eemeli requested changes Jul 23, 2026

View reviewed changes

Comment thread translate/src/modules/entities/components/StringNotFound.tsx Outdated

Comment thread translate/src/modules/entities/components/StringNotFound.tsx Outdated

ayshushus added 2 commits July 24, 2026 03:26

Refactor entityLocation destructuring, add if chain, remove duplicate…

8259af1

… strings

update tests

7cd1068

ayshushus requested a review from eemeli July 24, 2026 08:22

ayshushus requested a review from flodolo July 24, 2026 08:23

flodolo reviewed Jul 24, 2026

View reviewed changes

flodolo requested changes Jul 24, 2026

View reviewed changes

ayshushus and others added 3 commits July 24, 2026 06:28

Update translate/public/locale/en-US/translate.ftl

a66bfa5

Co-authored-by: Francesco Lodolo <flod@lodolo.net>

fix broken button height

3973a0b

Merge branch 'mozilla:main' into 2921

10fa552

	entities-StringNotFound--description-filtered = String { $stringId } is in { $stringResource } ({ $stringProject }), but it doesn’t match your current filters.
	entities-StringNotFound--description-filtered = String with internal ID <id>{ $stringId }</id> is in <id>{ $stringResource }</id> (project <project>{ $stringProject }</project>), but it doesn’t match your current filters.

Uh oh!

Conversation

ayshushus commented Jul 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ayshushus commented Jul 3, 2026

Uh oh!

eemeli left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ayshushus commented Jul 14, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

eemeli left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

flodolo left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

ayshushus commented Jul 3, 2026 •

edited

Loading