fix(versions): rm last main pins; fix examples#475
Merged
Conversation
amitchell-moz
requested review from
a team,
ahoneiser,
bkochendorfer,
bwells-moz,
cass-moz,
jasonthomas,
jbuck,
mikaeld and
whd
as code owners
Contributor
Release plan
|
jbuck
approved these changes
May 28, 2026
| # Currently Jenkins with plans to move to Airflow, see https://mozilla-hub.atlassian.net/browse/SVCSE-3005 | ||
| module "syndication_workgroup" { | ||
| source = "github.com/mozilla/terraform-modules//mozilla_workgroup?ref=main" | ||
| source = "github.com/mozilla/terraform-modules//mozilla_workgroup?ref=mozilla_workgroup-1.3.0" |
Member
There was a problem hiding this comment.
should this reference the local path instead?
Contributor
Author
There was a problem hiding this comment.
For modules that aren't tightly coupled (like the aws_gke_oidc_*s) I think it makes more sense to pin - that way breaking changes can be made to mozilla_workgroup without having to think about bigquery datasets
| @@ -1,14 +1,14 @@ | |||
| module "admins_workgroup" { | |||
| source = "github.com/mozilla/terraform-modules//mozilla_workgroup?ref=main" | |||
| source = "github.com/mozilla/terraform-modules//mozilla_workgroup?ref=mozilla_workgroup-1.3.0" | |||
Member
There was a problem hiding this comment.
Should this reference the local path instead?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Removes last remaining
mainpins ingoogle_bigquery_syndicated_dataset&google_permissionsto comply with our versioning strategy.Also replaces all main pins in examples.
Related Tickets & Documents