Bug 2034671 - Ingest suite-level replicates from performance data.#9459
Merged
gmierz merged 1 commit intomozilla:masterfrom May 7, 2026
Merged
Bug 2034671 - Ingest suite-level replicates from performance data.#9459gmierz merged 1 commit intomozilla:masterfrom
gmierz merged 1 commit intomozilla:masterfrom
Conversation
florinbilt
approved these changes
May 7, 2026
Collaborator
florinbilt
left a comment
There was a problem hiding this comment.
Hi, thanks for the patch! The change looks functionally correct. I have a few suggestions that I think would make it a bit cleaner.
- The new block in treeherder/etl/perf.py (lines 230-245) is almost identical to the existing subtest replicates handling (lines 318-333). Would you consider extracting a small helper to keep both call sites in sync going forward?
- if replicates and len(replicates) > 0 — the len(...) > 0 part is redundant since an empty list is already falsy. Just if replicates: would be enough.
- Would logger.warning (or logger.error) be more appropriate here?
- The new test covers the happy path nicely. Could we also add a quick assertion for the case where suite["replicates"] = []?
- I'm not entirely sure what the correct way to do this is, but in the subtest flow, replicate ingestion happens before should_mark_as_multi_commit, while in the new suite-level flow it happens after MultiCommitDatum.objects.create(...).
Overall, the patch looks functional and these are mostly stylistic suggestions, none of them are blockers. Thank you! r+
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch adds suite-level replicates ingestion for performance data. A unit test is also added for it.