Skip to content

ci: add npm OIDC release #54

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
khushi1033 merged 6 commits into from
Mar 16, 2026
Merged

ci: add npm OIDC release #54

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
f4d9576
ci: update release workflow for NPM OIDC auth
khushi1033 Mar 16, 2026
b97f039
ci: update release.yml
khushi1033 Mar 16, 2026
0ac0996
ci: use reuable workflow for pull-request
khushi1033 Mar 16, 2026
5fa6e17
ci: revert pull-request.yml
khushi1033 Mar 16, 2026
39fbea4
ci: Update .github/workflows/pull-request.yml
khushi1033 Mar 16, 2026
c2f5174
ci: update node versions
khushi1033 Mar 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .github/workflows/pull-request.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,12 +13,12 @@ jobs:

strategy:
matrix:
node-version: [18.x, 20.x, 21.x]
Copy link
Copy Markdown
Collaborator

@alexs-mparticle alexs-mparticle Mar 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The purpose of this matrix is to test a few different node versions in case there's any potential conflicts. I would use 24, 26 and 28 (if that's an option).

node-version: [24.x]
Copy link
Copy Markdown
Collaborator

@alexs-mparticle alexs-mparticle Mar 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we possibly use the reusable workflows instead? https://github.com/mParticle/mparticle-workflows/blob/main/.github/workflows/web-kit-pull-request.yml

Copy link
Copy Markdown
Contributor Author

@khushi1033 khushi1033 Mar 16, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gave it a go, but the reusable workflow requires ESLint and there's a bunch of linter errors to fix. Think it would be better to make a separate PR.


steps:
- uses: actions/checkout@v3
- uses: actions/checkout@v6
- name: Use Node.js ${{ matrix.node-version }}
uses: actions/setup-node@v1
uses: actions/setup-node@v6
with:
node-version: ${{ matrix.node-version }}
- run: npm ci
Expand Down
30 changes: 19 additions & 11 deletions .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,12 +20,12 @@ jobs:
needs: confirm-public-repo-master-branch
steps:
- name: Checkout
uses: actions/checkout@v3
uses: actions/checkout@v6

- name: NPM install
uses: actions/setup-node@v3
uses: actions/setup-node@v6
with:
node-version: 18.x
node-version: 24.x

- name: Run NPM CI
run: npm ci
Expand All @@ -37,7 +37,7 @@ jobs:
run: npm run test

- name: Archive npm failure logs
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v6
if: failure()
with:
name: npm-logs
Expand All @@ -51,7 +51,7 @@ jobs:
- confirm-public-repo-master-branch
steps:
- name: Checkout development branch
uses: actions/checkout@v3
uses: actions/checkout@v6
with:
repository: mparticle-integrations/mparticle-javascript-integration-google-tag-manager
ref: development
Expand All @@ -67,17 +67,21 @@ jobs:
- build-and-test
- create-release-branch
- confirm-public-repo-master-branch
permissions:
contents: write
issues: write
pull-requests: write
id-token: write # Required for OIDC authentication with npm
env:
GITHUB_TOKEN: ${{ secrets.MP_INTEGRATIONS_SEMANTIC_RELEASE_BOT }}
GIT_AUTHOR_NAME: mparticle-automation
GIT_AUTHOR_EMAIL: developers@mparticle.com
GIT_COMMITTER_NAME: mparticle-automation
GIT_COMMITTER_EMAIL: developers@mparticle.com
NPM_TOKEN: ${{ secrets.NPM_AUTH_TOKEN }}

steps:
- name: Checkout public master branch
uses: actions/checkout@v3
uses: actions/checkout@v6
with:
fetch-depth: 0
ref: master
Expand All @@ -94,9 +98,13 @@ jobs:
run: |
git pull origin release/${{ github.run_number }}
- name: Setup Node.js
uses: actions/setup-node@v3
uses: actions/setup-node@v6
with:
node-version: 18.x
node-version: 24.x
registry-url: 'https://registry.npmjs.org'

- name: Ensure npm CLI supports OIDC
run: npm install -g npm@latest

- name: Install dependencies
run: npm ci
Expand All @@ -110,7 +118,7 @@ jobs:
run: |
npx semantic-release
- name: Archive npm failure logs
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v6
if: failure()
with:
name: npm-logs
Expand All @@ -126,7 +134,7 @@ jobs:
runs-on: ubuntu-latest
steps:
- name: Checkout master branch
uses: actions/checkout@v3
uses: actions/checkout@v6
with:
fetch-depth: 0
repository: ${{ github.repository }}
Expand Down
Loading