ci: remove @semantic-release/github plugin from release config#7
Closed
jaissica12 wants to merge 1 commit into
Closed
ci: remove @semantic-release/github plugin from release config#7jaissica12 wants to merge 1 commit into
jaissica12 wants to merge 1 commit into
Conversation
Drops the GitHub Release creation step that was failing with a 404 so the release run completes and the sync-repository job can run. Version bump, CHANGELOG, dist build/commit, git tag, and npm publish are unaffected.
Contributor
Author
|
Closing this in favor of #6 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
releasejob was failing because@semantic-release/githubreturned a404when creating the GitHub Release. Because that step runs insidenpx semantic-release, the non-zero exit failed the wholereleasejob, and the downstreamsync-repositoryjob (needs: release) was skipped — leavingmain/developmentun-synced and therelease/<n>branch undeleted, even though npm publish and the git tag had already succeeded.This PR removes the
@semantic-release/githubplugin fromrelease.config.js. After this change,npx semantic-releaseperforms the full release except creating the GitHub Release:package.json,CHANGELOG.md,dist/(viascripts/release.sh),@semantic-release/exec),then exits successfully, so the
sync-repositoryjob runs and pushes the release commit tomain/developmentand deletes the release branch.Tradeoff: no GitHub Release entry is created (no Releases-page entry and no
distassets attached there). The git tag and the npm package are unaffected, and a GitHub Release can still be created manually for a given tag if desired (e.g.gh release create v<version> dist/RoktPayPlus-Kit.*).Testing Plan
release.config.jsstill parses and now resolves to the plugins:commit-analyzer,release-notes-generator,changelog,npm,exec,git(thegithubplugin is gone).dryRun: trueand confirmsemantic-releasecompletes with no GitHub Release404.v<version>tag is pushed, thereleasejob is green, and thesync-repositoryjob runs (pushes tomain/development, deletes therelease/<n>branch).