[1.21.1] Added blaze value sliders in-game#1161
Conversation
Add max heat capacity and max liquid capacity settings to the config file.
- Added new liquid capacity and heat capacity interactable value sliders, capped by the config value - Changed heat capacity range in the config file to 0t - 60 minutes and liquid capacity to 100 mB - 10B compared to previous commit which was uncapped on the higher end - Changed brazier block model and texture to support the rendered value slots (from create's ValueBoxTransform.Dual).
Base Create blaze burner cage can be used again, just different texture
Properly migrate liquid blaze burners from older mod versions
|
This is cool but a bit overengineered perhaps, id probably like a simpler solution but im not sure what that would be right now, ill have to think on this a bit |
|
I'm not sure the heat capacity slider is much needed actually, if that'd help with the over-engineering. The heat capacity is reached after already 400mB biofuel, which is not the most efficient, but fine probably. If liquid capacity is set to 100mB, this would be a total of "only" 500mB that gets pumped into the blaze burner on startup as opposed to 4.4B. I added it since it required 4B just to reach the heat capacity before the burn time fix (8B total). For other fuels (from other mods?) it may be more helpful, but for biofuel it isn't really needed that much perhaps. Unless heat capacity turns into a hard cap (as opposed to the soft cap that can be crossed currently due to the use of 100 mB in one go) and <100mB is used. For example, when the heat capacity is set to 1200 ticks and the remaining burn time drops to 1176, 1mB of biofuel would be used. Then the cumulative fuel use would need to be tracked to play the refuel sound in increments of 100mB (or it'll get real annoying real fast). But this would be even more over-engineered I think in your eyes. I think the value sliders are about as simple as you can get for having it be configurable. I put them on the bottom so anyone not needing the configurability isn't bothered by it and it doesn't affect the aesthetics of a free-standing burner. Alternative suggestion:
|
2 participants
Pull Request Checklist
Please review and complete all items before submitting your pull request:
MIT License Confirmation
Description
Building on my previous pull request (#1160) which added liquid blaze burner config values and fixed burn times for biofuel and blaze cakes, I wanted to try to add configurable sliders to the blaze burner. This is a design choice which, again, you must decide to keep or not, but I think it could be very useful if added because:
The current default config values do not allow you to set the blaze burner capacities higher than what they were before my changes, but they can be lowered to 0t for heat and 100 mB for liquid. The config values (in createaddition-common.toml) can be increased to 60 minutes for heat and 10 B for liquid to allow setting the sliders up to those values. When the liquid setting is lowered in-game, any excess is discharged. Lowering heat capacity currently has no impact until the remaining burn time lowers below the capacity, which prompts the use of 100mB. This could potentially be fixed by having refueling occur also in steps lower than 100 mB, but that's perhaps too much.
I also changed the model and textures of the burner a bit to accommodate the two sliders:
Here are also some pictures of the sliders:
Setting a liquid capacity in the top row of the slider (<1000 mB) prevents players from adding fuel with a bucket, which is not something you would expect to be possible anyways, as you can't add 100 mB out of an item bucket.
EDIT: just moved the scroll slots closer together in the last commit so the regular blaze burner cage model from base Create can be used again:
Related Issues
Closes no issues, as it's a new feature