fix(openresponses): support Codex WebSocket warm-up - #11608
Open
aim9sour wants to merge 1 commit into
Open
Conversation
Assisted-by: ChatGPT:GPT-5.6-Sol golangci-lint Signed-off-by: Abdullah Mansour <abdullahmansour.marketing@gmail.com>
aim9sour
force-pushed
the
fix/openresponses-codex-compat-master
branch
from
August 19, 2026 23:34
8a58e6d to
d7d249b
Compare
localai-org-maint-bot
requested changes
Aug 20, 2026
localai-org-maint-bot
left a comment
Collaborator
There was a problem hiding this comment.
The WebSocket changes look well covered, but this PR changes user-facing Responses API behavior without updating the corresponding guide. LocalAI's docs-with-code rule requires that update in the same change.
Please add a short WebSocket Responses section to docs/content/features/text-generation.md that documents:
- connecting to
/v1/responsesover WebSocket and waiting for a terminal event before sending the nextresponse.create; generate: falsereturningresponse.createdandresponse.completedwithout inference, and using its ID asprevious_response_id;store: falseresponse IDs being scoped to the current WebSocket connection; and- multi-hop
previous_response_idchains replaying the complete conversation.
I did not push this minor docs fix because a bot-authored commit would fail DCO, and I cannot preserve your sign-off on content you did not commit.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This follows up on #8644 and #8676 and fixes remaining Responses WebSocket compatibility gaps exposed by Codex:
generate:falsewarm-up without inference and keepsstore:falseresponses in a connection-local storeprevious_response_idchains across connection-local and global storesweb_searchandnamespacefrom being coerced into function toolsstoreflag in WebSocket response resourcesresponse is already in progresserrorRegression coverage includes connection isolation, warm-up continuation, mixed-store ancestry, native tool filtering, and immediate sequential turns.
Notes for Reviewers
Verified on the final commit:
go test ./core/http/endpoints/openresponses ./core/schema --count=1go test -race ./core/http/endpoints/openresponses --count=1go vet ./core/http/endpoints/openresponses ./core/schema--repeat=3)make lintwith the CI toolchain (Go 1.26.1 + golangci-lint 2.11.4): 0 issuesmake buildwith Go 1.26.1A broader
make testwas also attempted in the earlier reproduction worktree. It reached unrelated container-backed tests and failed because this environment has no Docker/rootless Docker provider (dockeris not installed and no Docker socket/runtime is present). The targeted, race, lint, E2E, vet, and build checks above are green.Per the repository AI contribution policy, the commit includes an
Assisted-bytrailer and is DCO-signed by the author.[Signed commits]