Edit pyproject.toml file's tool.uv.sources option if it is a uv-managed project#81
Open
erral wants to merge 21 commits intomxstack:mainfrom
Open
Edit pyproject.toml file's tool.uv.sources option if it is a uv-managed project#81erral wants to merge 21 commits intomxstack:mainfrom
tool.uv.sources option if it is a uv-managed project#81erral wants to merge 21 commits intomxstack:mainfrom
Conversation
Co-authored-by: Steve Piercy <web@stevepiercy.com>
stevepiercy
approved these changes
Mar 28, 2026
jensens
requested changes
Mar 29, 2026
Member
jensens
left a comment
jensens
left a comment
There was a problem hiding this comment.
Feature concept is sound but needs rework in a few areas before merge. See inline comments.
Author
|
Thank you both for the review, I have updated the code to match your review notes. |
Author
|
Gemini suggested doing the |
jensens
requested changes
Apr 1, 2026
Member
jensens
left a comment
jensens
left a comment
There was a problem hiding this comment.
Most prior issues addressed well. One critical ordering bug remains, plus a few smaller items.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For uv-managed projects (those with
[tool.uv] managed=trueinpyproject.toml) write in the[tool.uv.sources]option of thepyproject.tomlthe paths to the downloaded packages.See erral/mxdev-uv-pyproject-updater#1 and plone/cookieplone-templates#352 for reference