fix: handle wine properly by Arqu · Pull Request #3902 · n0-computer/iroh

Arqu · 2026-02-02T09:36:38Z

Tests that iroh works under wine & proton in CI

Depends on

Ref: #3901

github-actions · 2026-02-02T09:39:17Z

Documentation for this PR has been generated and is available at: https://n0-computer.github.io/iroh/pr/3902/docs/iroh/

Last updated: 2026-04-07T16:26:35Z

flub · 2026-03-30T14:52:49Z

would be great to get this mergeable again

jestarray · 2026-03-31T21:21:53Z

if this ever does get merged, please PR the fix to quinn as well, thanks!

Arqu · 2026-04-03T07:30:55Z

if this ever does get merged, please PR the fix to quinn as well, thanks!

The fixes are already merged this is just the final step to get it into CI too. The fixes are available in our fork of quinn (noq)

Adds netwatch patch from fix-rebind branch which fixes: - Socket stuck in Closed state after failed rebind (AddrInUse) - SO_REUSEADDR to handle Wine's non-instantaneous socket close

Network change tests are too flaky under Wine emulation due to slow/unreliable socket rebinding. Skip them in the Wine nextest profile until Wine compatibility improves. Also reverts the run_roundtrip timeout back to 4s.

github-actions · 2026-04-03T11:06:30Z

Netsim report & logs for this PR have been generated and is available at: LOGS
This report will remain available for 3 days.

Last updated for commit: 067c40b

flub

I don't know what to make of the Cargo.lock changes. There are no Cargo.toml changes and some dependencies are getting newer versions, some are getting older versions. Some even go from a release to an RC before the release.

Is this the result of running cargo update on windows or something? CI claims it doesn't break any of the other builds, but what about the inverse? Will we break windows once we update a dep elsewhere? Is this change needed or accidental?

This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [iroh](https://github.com/n0-computer/iroh) | workspace.dependencies | minor | `0.97.0` → `0.98.0` | --- ### Release Notes <details> <summary>n0-computer/iroh (iroh)</summary> ### [`v0.98.0`](https://github.com/n0-computer/iroh/blob/HEAD/CHANGELOG.md#0980---2026-04-17) [Compare Source](n0-computer/iroh@v0.97.0...v0.98.0) ##### ⛰️ Features - *(iroh)* Avoid allocations in `AddrFilter` ([#4018](n0-computer/iroh#4018)) - ([d26cbd2](n0-computer/iroh@d26cbd2)) - *(iroh)* Pluggable crypto backends ([#3992](n0-computer/iroh#3992)) - ([387c2e4](n0-computer/iroh@387c2e4)) - *(iroh)* Add ability to configure external addrs ([#4098](n0-computer/iroh#4098)) - ([372aab9](n0-computer/iroh@372aab9)) - *(iroh)* Do not advertise deprecated IPv6 addrs ([#4106](n0-computer/iroh#4106)) - ([b2b1d46](n0-computer/iroh@b2b1d46)) - *(iroh-relay)* Expose more metrics on the relay server ([#4085](n0-computer/iroh#4085)) - ([ee844a6](n0-computer/iroh@ee844a6)) - Expose the new fn decrypt on noq. ([#4002](n0-computer/iroh#4002)) - ([197d8db](n0-computer/iroh@197d8db)) - Update noq and net-tools to latest ([#4088](n0-computer/iroh#4088)) - ([159a5cf](n0-computer/iroh@159a5cf)) - Rate limiting in router ([#3951](n0-computer/iroh#3951)) - ([ea7a634](n0-computer/iroh@ea7a634)) - Update relay protocol to iroh-relay-v2, add new Health frame, test protocol update mechanism ([#3955](n0-computer/iroh#3955)) - ([0a22d76](n0-computer/iroh@0a22d76)) - Update to noq\@0.18 ([#4121](n0-computer/iroh#4121)) - ([72e4538](n0-computer/iroh@72e4538)) - Vendor pkarr implementation ([#4026](n0-computer/iroh#4026)) - ([3ab6222](n0-computer/iroh@3ab6222)) ##### 🐛 Bug Fixes - *(ci)* Install cmake and nasm for aws-lc-sys on Windows ([#4032](n0-computer/iroh#4032)) - ([405de1d](n0-computer/iroh@405de1d)) - *(iroh)* \[**breaking**] Faster relay health check after network change ([#4041](n0-computer/iroh#4041)) - ([b11b0eb](n0-computer/iroh@b11b0eb)) - *(iroh)* `Endpoint::online` should only return once connected to a relay ([#4115](n0-computer/iroh#4115)) - ([3424c6d](n0-computer/iroh@3424c6d)) - *(iroh)* \[**breaking**] Don't stop address lookup when one service errors ([#4126](n0-computer/iroh#4126)) - ([321443d](n0-computer/iroh@321443d)) - *(iroh)* Don't falsely report home relay as connected on change ([#4136](n0-computer/iroh#4136)) - ([1b04d34](n0-computer/iroh@1b04d34)) - *(iroh-relay)* Send EndpointGone message to the right peers ([#4079](n0-computer/iroh#4079)) - ([6be4b3c](n0-computer/iroh@6be4b3c)) - *(iroh-relay)* Treat frames not allowed in a protocol version as error ([#4127](n0-computer/iroh#4127)) - ([1c92a39](n0-computer/iroh@1c92a39)) - Improve holepunching after network changes ([#3928](n0-computer/iroh#3928)) - ([cc21f51](n0-computer/iroh@cc21f51)) - Poll for default route with exponential backoff after network change ([#4039](n0-computer/iroh#4039)) - ([dc01a77](n0-computer/iroh@dc01a77)) - Modify test\_ip\_wins\_over\_custom so it is a noop if no ip transport is… ([#4048](n0-computer/iroh#4048)) - ([b141e02](n0-computer/iroh@b141e02)) - Increase path idle timeouts and configure relay paths ([#4038](n0-computer/iroh#4038)) - ([eba6afc](n0-computer/iroh@eba6afc)) - Handle wine properly ([#3902](n0-computer/iroh#3902)) - ([8bf7002](n0-computer/iroh@8bf7002)) - Set default crypto provider for iroh-relay binary ([#4087](n0-computer/iroh#4087)) - ([2433645](n0-computer/iroh@2433645)) ##### 🚜 Refactor - *(iroh)* \[**breaking**] Improve address lookup registry ([#4130](n0-computer/iroh#4130)) - ([481c870](n0-computer/iroh@481c870)) - *(iroh, iroh-relay)* \[**breaking**] Mark public types as non\_exhaustive ([#4107](n0-computer/iroh#4107)) - ([86d3ac6](n0-computer/iroh@86d3ac6)) - *(iroh-base)* \[**breaking**] Don't expose third-party error types in iroh-base ([#4073](n0-computer/iroh#4073)) - ([d803dfe](n0-computer/iroh@d803dfe)) - *(iroh-base)* \[**breaking**] Rename `CustomAddr::as_vec` to `CustomAddr::to_vec` and improve docs ([#4074](n0-computer/iroh#4074)) - ([3077f17](n0-computer/iroh@3077f17)) - *(iroh-base)* \[**breaking**] Change `SecretKey::generate` to not take an `Rng` arg ([#4075](n0-computer/iroh#4075)) - ([36781ad](n0-computer/iroh@36781ad)) - *(iroh-relay)* \[**breaking**] Proper timeouts on relay connections ([#4083](n0-computer/iroh#4083)) - ([79bb0e4](n0-computer/iroh@79bb0e4)) - Use latest noq api ([#4057](n0-computer/iroh#4057)) - ([8af8370](n0-computer/iroh@8af8370)) - Remove needless alloc in relay server ([#4084](n0-computer/iroh#4084)) - ([40b50a1](n0-computer/iroh@40b50a1)) - Move to\_z32/from\_z32 into iroh-base and remove EndpointIdExt trait ([#4133](n0-computer/iroh#4133)) - ([382bf36](n0-computer/iroh@382bf36)) ##### 🧪 Testing - *(iroh)* Add patchbay test matrix for switching uplinks ([#4095](n0-computer/iroh#4095)) - ([d72f1cb](n0-computer/iroh@d72f1cb)) - *(iroh)* Add more patchbay tests and improve existing tests ([#4118](n0-computer/iroh#4118)) - ([f5ec24a](n0-computer/iroh@f5ec24a)) - *(iroh)* Improve patchbay NAT matrix ([#4135](n0-computer/iroh#4135)) - ([2ad657a](n0-computer/iroh@2ad657a)) - Fix ip\_wins\_over\_custom flakiness ([#4047](n0-computer/iroh#4047)) - ([174b58b](n0-computer/iroh@174b58b)) - Add patchbay tests ([#3986](n0-computer/iroh#3986)) - ([2ab1240](n0-computer/iroh@2ab1240)) - Improve patchbay test setup ([#4078](n0-computer/iroh#4078)) - ([9b01751](n0-computer/iroh@9b01751)) - Minor patchbay test improvements ([#4091](n0-computer/iroh#4091)) - ([0cc2441](n0-computer/iroh@0cc2441)) ##### ⚙️ Miscellaneous Tasks - *(ci)* Move more CI jobs to self hosted runners ([#4072](n0-computer/iroh#4072)) - ([54442c3](n0-computer/iroh@54442c3)) - *(iroh)* Update hickory to 0.26.0-beta.4 and use exact-version deps for prereleased crates ([#4117](n0-computer/iroh#4117)) - ([f829593](n0-computer/iroh@f829593)) - *(iroh-bench)* Allow configuring the number of worker threads for each endpoint in iroh-bench ([#4063](n0-computer/iroh#4063)) - ([065b448](n0-computer/iroh@065b448)) - Update to netwatch\@0.16 and portmapper\@0.16 ([#4128](n0-computer/iroh#4128)) - ([24efedf](n0-computer/iroh@24efedf)) - Fix changelog generation - ([08c6454](n0-computer/iroh@08c6454)) ##### Deps - *(iroh)* Update patchbay to 0.5 ([#4097](n0-computer/iroh#4097)) - ([811a062](n0-computer/iroh@811a062)) - Bump noq and net-tools ([#4113](n0-computer/iroh#4113)) - ([184e378](n0-computer/iroh@184e378)) ##### Examples - *(iroh)* Allow to configure the receive window in the transfer example ([#4082](n0-computer/iroh#4082)) - ([c865251](n0-computer/iroh@c865251)) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).  Reviewed-on: https://git.erwanleboucher.dev/eleboucher/towonel/pulls/19

Arqu self-assigned this Feb 2, 2026

Arqu added the test label Feb 2, 2026

Arqu added this to iroh Feb 2, 2026

Arqu added this to the iroh: v0.97 milestone Feb 2, 2026

github-project-automation Bot moved this to 🚑 Needs Triage in iroh Feb 2, 2026

Arqu moved this from 🚑 Needs Triage to 🏗 In progress in iroh Feb 2, 2026

dignifiedquire changed the title ~~feat(ci): wine testing~~ ci: test on wine Feb 2, 2026

Arqu moved this from 🏗 In progress to 👀 In review in iroh Feb 3, 2026

dignifiedquire force-pushed the arqu/wine_ci branch 5 times, most recently from 1a013e7 to 3b1dcf3 Compare February 6, 2026 12:04

dignifiedquire changed the title ~~ci: test on wine~~ fix: handle wine properly Feb 6, 2026

dignifiedquire force-pushed the arqu/wine_ci branch from 9461c76 to 9d84ef5 Compare February 16, 2026 16:42

dignifiedquire modified the milestones: iroh: v0.97, iroh: v0.98 Mar 10, 2026

jestarray mentioned this pull request Mar 29, 2026

wine linux is not working quinn-rs/quinn#2587

Open

Arqu added 8 commits April 3, 2026 09:33

feat(ci): wine testing

d5bdaa5

use self hosted runners

2e01db5

deal with warnings later

e352a50

flags 😭

abc6563

fumbling

8c9e6ab

mingw cant handle debug mode

61389f4

deps

ad22e5a

make failed tests fail CI

bd37e54

dignifiedquire added 7 commits April 3, 2026 09:35

patch in latest quinn

678647d

ci: try using nextest

43fbb3e

ci: fail fast

1900ca5

fix(iroh): patch netwatch for socket rebind fix on Wine

3498491

Adds netwatch patch from fix-rebind branch which fixes: - Socket stuck in Closed state after failed rebind (AddrInUse) - SO_REUSEADDR to handle Wine's non-instantaneous socket close

chore: update netwatch lockfile

c92f5f8

test: increase timeout

66a57f1

fix(ci): skip network_change tests under Wine

da70915

Network change tests are too flaky under Wine emulation due to slow/unreliable socket rebinding. Skip them in the Wine nextest profile until Wine compatibility improves. Also reverts the run_roundtrip timeout back to 4s.

Arqu force-pushed the arqu/wine_ci branch from 893287a to da70915 Compare April 3, 2026 07:38

Arqu requested review from dignifiedquire and flub April 3, 2026 07:38

flub reviewed Apr 3, 2026

View reviewed changes

deps

f277b3d

Arqu force-pushed the arqu/wine_ci branch from 57be279 to f277b3d Compare April 7, 2026 07:58

Merge branch 'main' into arqu/wine_ci

46d0bba

dignifiedquire approved these changes Apr 7, 2026

View reviewed changes

Arqu added 2 commits April 7, 2026 12:24

Merge branch 'main' into arqu/wine_ci

4b30b7f

Merge branch 'main' into arqu/wine_ci

22ec23e

Arqu merged commit 8bf7002 into main Apr 7, 2026
31 of 32 checks passed

github-project-automation Bot moved this from 👀 In review to ✅ Done in iroh Apr 7, 2026

Arqu deleted the arqu/wine_ci branch April 7, 2026 16:38

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: handle wine properly#3902

fix: handle wine properly#3902
Arqu merged 19 commits intomainfrom
arqu/wine_ci

Arqu commented Feb 2, 2026 •

edited by dignifiedquire

Loading

Uh oh!

github-actions Bot commented Feb 2, 2026 •

edited

Loading

Uh oh!

flub commented Mar 30, 2026

Uh oh!

jestarray commented Mar 31, 2026

Uh oh!

Arqu commented Apr 3, 2026

Uh oh!

github-actions Bot commented Apr 3, 2026 •

edited

Loading

Uh oh!

flub left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

Arqu commented Feb 2, 2026 • edited by dignifiedquire Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Feb 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

flub commented Mar 30, 2026

Uh oh!

jestarray commented Mar 31, 2026

Uh oh!

Arqu commented Apr 3, 2026

Uh oh!

github-actions Bot commented Apr 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

flub left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Arqu commented Feb 2, 2026 •

edited by dignifiedquire

Loading

github-actions Bot commented Feb 2, 2026 •

edited

Loading

github-actions Bot commented Apr 3, 2026 •

edited

Loading