Skip to content

Fix nasa#497, Suppress ignored return value warning in codeSonar#500

Merged
myc-yang merged 1 commit into
nasa:devfrom
myc-yang:497-check-return-value-cfe-sb-deletepipe-disableengine-v2
Jun 2, 2026
Merged

Fix nasa#497, Suppress ignored return value warning in codeSonar#500
myc-yang merged 1 commit into
nasa:devfrom
myc-yang:497-check-return-value-cfe-sb-deletepipe-disableengine-v2

Conversation

@myc-yang
Copy link
Copy Markdown
Contributor

@myc-yang myc-yang commented May 28, 2026

Checklist (Please check before submitting)

Describe the contribution
In fsw/src/cf_cfdp.c in the function CF_CFDP_DisableEngine(), the return value of CFE_SB_DeletePipe() is ignored. Issue is captured in #497. I suppressed the warning by casting a (void) for the CFE_SB_DeletePipe() and putting a comment saying that codeSonar should ignore the warning.

Testing performed
I updated and ran the unit tests function Test_CF_CFDP_DisableEngine() in unit-test/cf_cfdp_tests.c,

Expected behavior changes

  • None

System(s) tested on

  • Hardware: PC
  • OS: Ubuntu 18.04
  • Versions: [e.g. cFE 6.6, OSAL 4.2, PSP 1.3 for mcp750, any related apps or tools]

Additional context
Add any other context about the contribution here.

Third party code
If included, identify any third party code and provide text file of license

Contributor Info - All information REQUIRED for consideration of pull request
Michael Yang NASA/GSFC

@myc-yang myc-yang force-pushed the 497-check-return-value-cfe-sb-deletepipe-disableengine-v2 branch from 8e28f40 to ed34448 Compare May 28, 2026 19:44
@myc-yang myc-yang requested a review from jphickey June 1, 2026 12:12
@myc-yang myc-yang self-assigned this Jun 1, 2026
@myc-yang myc-yang marked this pull request as ready for review June 1, 2026 12:15
@myc-yang myc-yang merged commit 7fa52e4 into nasa:dev Jun 2, 2026
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants