Fix nasa#497, Suppress ignored return value warning in codeSonar#500
Merged
myc-yang merged 1 commit intoJun 2, 2026
Conversation
8e28f40 to
ed34448
Compare
This was referenced Jun 1, 2026
jphickey
approved these changes
Jun 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist (Please check before submitting)
Describe the contribution
In
fsw/src/cf_cfdp.cin the functionCF_CFDP_DisableEngine(), the return value ofCFE_SB_DeletePipe()is ignored. Issue is captured in #497. I suppressed the warning by casting a(void)for theCFE_SB_DeletePipe()and putting a comment saying that codeSonar should ignore the warning.Testing performed
I updated and ran the unit tests function
Test_CF_CFDP_DisableEngine()inunit-test/cf_cfdp_tests.c,Expected behavior changes
System(s) tested on
Additional context
Add any other context about the contribution here.
Third party code
If included, identify any third party code and provide text file of license
Contributor Info - All information REQUIRED for consideration of pull request
Michael Yang NASA/GSFC