fix: correct drop-shadow output format and filter function bugs#309
Open
YevheniiKotyrlo wants to merge 1 commit intonativewind:mainfrom
Open
fix: correct drop-shadow output format and filter function bugs#309YevheniiKotyrlo wants to merge 1 commit intonativewind:mainfrom
YevheniiKotyrlo wants to merge 1 commit intonativewind:mainfrom
Conversation
2a76ebc to
3d5024b
Compare
3d5024b to
9b87ebe
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Three fixes in
src/native/styles/functions/filters.ts:1.
blurRadius→standardDeviationin drop-shadow handlerReact Native's
DropShadowValuetype expectsstandardDeviation, notblurRadius:The handler was producing
{ blurRadius: 6 }— React Native ignores this unrecognized property, resulting in drop shadows with zero blur.2.
["color", "string"]→["color", "color"]in drop-shadow handlerThe
"string"type in the shorthand handler rejects platform color objects (fromcurrentcolorresolution).box-shadow.tsandtext-shadow.tsboth correctly use["color", "color"]— this aligns the drop-shadow handler.3.
hueRotate→opacityin opacity filter function (copy-paste)The
opacityfunction returned{ hueRotate: ... }instead of{ opacity: ... }— copied from thehueRotatefunction above it.Changes
src/native/styles/functions/filters.tssrc/__tests__/native/filters.test.tsxsrc/__tests__/vendor/tailwind/filters.test.tsxblurRadius→standardDeviationin existing assertionsTest plan
npx jest src/__tests__/native/filters.test.tsx— 7 tests pass (drop-shadow basic, color-first, no-blur, CSS variable, runtime variable, Tailwind v4 @Property pattern, opacity key)npx jest src/__tests__/vendor/tailwind/filters.test.tsx— 24 tests pass (existing, assertions updated)main)tsc --noEmit— cleaneslint— clean