Remove legacy old ObjectTree path#1280
Open
seongahjo wants to merge 14 commits into
Open
Conversation
github-actions
Bot
requested review from
SooKim1110,
acktsap,
benelog,
jwChung and
mhyeon-lee
seongahjo
force-pushed
the
sa/remove-node-tree
branch
12 times, most recently
from
91c9e6c to
84e83eb
Compare
seongahjo
commented
May 19, 2026
| public boolean match(Property property) { | ||
| return Types.getActualType(property.getType()).isArray() | ||
| || GenericArrayType.class.isAssignableFrom(property.getType().getClass()); | ||
| return property.getJvmType().getRawType().isArray(); |
Contributor
Author
There was a problem hiding this comment.
GenericArrayType.class.isAssignableFrom(property.getType().getClass());
This has already been dealt with in the JvmType.
Remove the legacy tree package, manipulator, expression, and NodeTreeAdapter classes. Introduce the new adapter machinery with JvmTypeSystem SPI, migrate the API surface, and adapt downstream modules and integration tests. Guard the interface branch in ValueProjectionAssembler against self-recursive types to prevent StackOverflowError on self-typed wither interfaces.
…me configureForOptions
seongahjo
force-pushed
the
sa/remove-node-tree
branch
from
1ff4984 to
ca479a0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Remove legacy old ObjectTree path
How Has This Been Tested?