add USS metric from smaps#347
Open
DanielLeone wants to merge 1 commit into
Open
Conversation
Signed-off-by: Daniel Leone <mail.dleone@gmail.com>
DanielLeone
force-pushed
the
add_uss_metric
branch
from
a70f941 to
c608219
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, thanks for the work on this project - I've been using it recently to debug a memory leak and it's been very useful.
I noticed that USS metrics were missing though and they seem to go hand-in-hand with PSS, and I saw that it was fairly trivial to add support for it - so I did.
Here's my use case:
Watching memory growth for individual postgres connections over time, we can see Resident and PSS memory increases but USS is staying the same
I think in this particular context, this is largely okay, and thus, it's quite useful to know that USS is not growing while shared memory is.
Let me know what you think - thanks