Update simple-game to be the version of using fiber-sdk#58
Update simple-game to be the version of using fiber-sdk#58ashuralyk wants to merge 1 commit intonervosnetwork:masterfrom
fiber-sdk#58Conversation
|
@ashuralyk is attempting to deploy a commit to the cryptape Team on Vercel. A member of the Team first needs to authorize it. |
|
@ashuralyk
Let me know what you think! |
|
@ashuralyk The repository link shifted from the official repository to a personal repository, which is detrimental to long-term maintenance. --repeat issue The code in the simple-game directory was not updated synchronously. The PR only modified the documentation, but the actual code in the local simple-game directory remains the old version. If users clone the official repository's simple-game as per the documentation, the code is completely incompatible with the documentation. The newInvoice function lacks the finalExpiryDelta parameter. According to the documentation example from @ckb-ccc/fiber on npm, the finalExpiryDelta parameter is required: The return value structure of listChannels has changed. The SDK version of listChannels directly returns a Channel[] array, while the old version returns a { channels: Channel[] } wrapper object. The code in the PR documentation correctly accommodates this, but simple-game hasn't changed it. The peerID has been hardcoded to change, and this part hasn't been updated in sync with the peerID in the example code block (the documentation still shows the old peerID as an example). |
There soon would be an official
fiber-sdkto ship fiber development simplicity to the public, so for the best exploration of it, it's good to apply demo changes directly on fiber-docs here.note: some file changes are from code formatter.