refactor: flatten nesting in CurrentUser::getCloudId() with early return#2567
Open
miaulalala wants to merge 1 commit intomasterfrom
Open
refactor: flatten nesting in CurrentUser::getCloudId() with early return#2567miaulalala wants to merge 1 commit intomasterfrom
miaulalala wants to merge 1 commit intomasterfrom
Conversation
Invert the cached-value guard from wrapping the entire body to an early return, removing one level of nesting. Adds three tests covering the cache hit, session-user, and token-fallback paths. Signed-off-by: Anna Larch <anna@nextcloud.com> AI-Assisted-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Activity
 |
||||||||||||||||||||||||||||
| Project |
Activity
|
| Branch Review |
refactor/get-cloud-id-early-return
|
| Run status |
|
| Run duration | 01m 56s |
| Commit |
|
| Committer | Anna |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
 |
0
|
 |
0
|
 |
1
|
 |
0
|
 |
9
|
| View all changes introduced in this branch ↗︎ | |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Inverts the
$cloudId !== falsecache guard inCurrentUser::getCloudId()into an early return, removing one level of nesting from the fetch path.Adds three tests that were missing: cache hit (no session call), session-user path, and token-fallback path.
Test plan
testGetCloudId*tests (3 tests) — greenCurrentUserTestsuite — green🤖 Generated with Claude Code