refactor: replace magic batch-time seconds with named constants#2569
Open
miaulalala wants to merge 1 commit intomasterfrom
Open
refactor: replace magic batch-time seconds with named constants#2569miaulalala wants to merge 1 commit intomasterfrom
miaulalala wants to merge 1 commit intomasterfrom
Conversation
Add BATCH_TIME_HOURLY/DAILY/WEEKLY to UserSettings alongside the existing EMAIL_SEND_* constants. Replace all bare 3600 / 3600*24 / 3600*24*7 literals in MailQueueHandler and UserSettings with the new constants. Signed-off-by: Anna Larch <anna@nextcloud.com> AI-Assisted-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Activity
 |
||||||||||||||||||||||||||||
| Project |
Activity
|
| Branch Review |
refactor/batch-time-constants
|
| Run status |
|
| Run duration | 01m 59s |
| Commit |
|
| Committer | Anna |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
 |
0
|
 |
0
|
 |
1
|
 |
0
|
 |
9
|
| View all changes introduced in this branch ↗︎ | |
benjaminfrueh
approved these changes
May 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds
BATCH_TIME_HOURLY(3600),BATCH_TIME_DAILY(86400), andBATCH_TIME_WEEKLY(604800) constants toUserSettingsalongside the existingEMAIL_SEND_*constants. Replaces all bare numeric literals (3600,3600 * 24,3600 * 24 * 7) inMailQueueHandlerandUserSettingswith the new constants.Test plan
UserSettingsTest— greenMailQueueHandlerTest— green🤖 Generated with Claude Code