refactor: extract email batch-time logic into UserSettings::getEmailBatchTimeSetting()#2570
Open
miaulalala wants to merge 1 commit intomasterfrom
Open
refactor: extract email batch-time logic into UserSettings::getEmailBatchTimeSetting()#2570miaulalala wants to merge 1 commit intomasterfrom
miaulalala wants to merge 1 commit intomasterfrom
Conversation
…atchTimeSetting() The pattern `getUserSetting($user, 'email', $type) ? getUserSetting($user, 'setting', 'batchtime') : false` was duplicated 7 times in FilesHooks and once in Consumer. Extract it to a named method on UserSettings and replace all call sites. Adds two unit tests covering the enabled and disabled paths. Signed-off-by: Anna Larch <anna@nextcloud.com> AI-Assisted-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Activity
 |
||||||||||||||||||||||||||||
| Project |
Activity
|
| Branch Review |
refactor/email-batchtime-helper
|
| Run status |
|
| Run duration | 02m 05s |
| Commit |
|
| Committer | Anna |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
 |
0
|
 |
0
|
 |
1
|
 |
0
|
 |
9
|
| View all changes introduced in this branch ↗︎ | |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The pattern:
was duplicated 7 times in
FilesHooksand once inConsumer. It encodes a single piece of domain logic: "return the batch-time delay if email is enabled for this user and type, otherwise false."Extracted to
UserSettings::getEmailBatchTimeSetting(string $user, string $type): int|falseand replaced all 8 call sites. Updated the 5 affectedFilesHooksTestmock setups accordingly.Test plan
UserSettingsTestcases (email disabled → false, email enabled → batchtime) — greenUserSettingsTestfull suite — greenFilesHooksTestfull suite — greenConsumerTestfull suite — green🤖 Generated with Claude Code