refactor: deduplicate getHTMLSubject() via HTMLSubjectFormatter#2571
Open
miaulalala wants to merge 1 commit intomasterfrom
Open
refactor: deduplicate getHTMLSubject() via HTMLSubjectFormatter#2571miaulalala wants to merge 1 commit intomasterfrom
miaulalala wants to merge 1 commit intomasterfrom
Conversation
The method was copy-pasted identically in MailQueueHandler and DigestSender. Extract it to a static HTMLSubjectFormatter::format() class, add four unit tests covering the no-rich-subject fallback, file parameters, name parameters, and linked parameters. Both callers now delegate to the single implementation. Signed-off-by: Anna Larch <anna@nextcloud.com> AI-Assisted-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Activity
 |
||||||||||||||||||||||||||||
| Project |
Activity
|
| Branch Review |
refactor/html-subject-trait
|
| Run status |
|
| Run duration | 01m 57s |
| Commit |
|
| Committer | Anna |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
 |
0
|
 |
0
|
 |
1
|
 |
0
|
 |
9
|
| View all changes introduced in this branch ↗︎ | |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
getHTMLSubject()was copy-pasted identically inMailQueueHandlerandDigestSender— any bug fix or change had to be applied twice.Extracted to a static
HTMLSubjectFormatter::format(IEvent): stringclass. Both callers now delegate to the single implementation; theirgetHTMLSubject()methods become one-liners.Also adds four focused unit tests that were previously missing: no-rich-subject fallback (HTML-escaping), file-type parameter (uses
path), non-file parameter (usesname), and parameter with a link (renders<a>).Test plan
HTMLSubjectFormatterTestcases — green🤖 Generated with Claude Code