refactor(types): add native parameter and return types to UserSettings#2572
Open
miaulalala wants to merge 1 commit intomasterfrom
Open
refactor(types): add native parameter and return types to UserSettings#2572miaulalala wants to merge 1 commit intomasterfrom
miaulalala wants to merge 1 commit intomasterfrom
Conversation
All six public/protected methods now carry PHP 8.x native types instead of relying on docblocks alone. Two test mocks that used willReturnMap were migrated to willReturnCallback so they return a typed default (false / []) instead of null when no entry matches. Signed-off-by: Anna Larch <anna@nextcloud.com> AI-Assisted-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Activity
 |
||||||||||||||||||||||||||||
| Project |
Activity
|
| Branch Review |
refactor/type-safety-usersettings
|
| Run status |
|
| Run duration | 02m 03s |
| Commit |
|
| Committer | Anna |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
 |
0
|
 |
0
|
 |
1
|
 |
0
|
 |
9
|
| View all changes introduced in this branch ↗︎ | |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
UserSettingsmethods (getUserSetting,getAdminSetting,getDefaultSetting,canModifySetting,getNotificationTypes,filterUsersBySetting)willReturnMaptowillReturnCallbackso they return a typed default (false/[]) instead ofnullwhen no map entry matchesTest plan
composer test:unitpasses (328 tests)🤖 AI-Assisted-By: Claude Sonnet 4.6 noreply@anthropic.com