[stable33] refactor: clarify fileCreate() condition by making the specific case explicit#2576
Open
backportbot[bot] wants to merge 1 commit intostable33from
Open
[stable33] refactor: clarify fileCreate() condition by making the specific case explicit#2576backportbot[bot] wants to merge 1 commit intostable33from
backportbot[bot] wants to merge 1 commit intostable33from
Conversation
…explicit The original condition used a double-negative (De Morgan) form that made the public-upload branch hard to read as the else. Rewrite as a positive check — empty identifier AND public share token — and make the public-upload path the if-branch. Adds the missing fourth test case (non-empty identifier + isPublicShareToken=true → regular upload). Signed-off-by: Anna Larch <anna@nextcloud.com> AI-Assisted-By: Claude Sonnet 4.6 <noreply@anthropic.com>
miaulalala
approved these changes
May 7, 2026
Activity
 |
||||||||||||||||||||||||||||
| Project |
Activity
|
| Branch Review |
backport/2568/stable33
|
| Run status |
|
| Run duration | 03m 23s |
| Commit |
|
| Committer | backportbot[bot] |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
 |
0
|
 |
0
|
 |
1
|
 |
0
|
 |
9
|
| View all changes introduced in this branch ↗︎ | |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of PR #2568