[stable33] refactor: flatten nesting with early returns in FilesHooks and ViewInfoCache#2581
Merged
miaulalala merged 2 commits intostable33from May 7, 2026
Merged
[stable33] refactor: flatten nesting with early returns in FilesHooks and ViewInfoCache#2581miaulalala merged 2 commits intostable33from
miaulalala merged 2 commits intostable33from
Conversation
- Data::setOffsetFromSince(): invert guards with early returns and extract the repeated fallback fetch into getFirstKnownActivityHeader() - MailQueueHandler::getAffectedUsers(): early return in the restrictEmails branch and extract the duplicated result loop into fetchAffectedUsers() Signed-off-by: Anna Larch <anna@nextcloud.com> AI-Assisted-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…foCache - FilesHooks::unShare(): invert guard clause to early return; add tests covering the guard (non-file/folder nodeType, deleted node) and all dispatch branches (TYPE_USER, TYPE_GROUP, TYPE_LINK) - FilesHooks::unShareSelf(): same guard-inversion treatment - ViewInfoCache::findInfoById(): replace nested try-catch and $notFound flag with sequential try-catch blocks and early returns Signed-off-by: Anna Larch <anna@nextcloud.com> AI-Assisted-By: Claude Sonnet 4.6 <noreply@anthropic.com>
miaulalala
approved these changes
May 7, 2026
Activity
 |
||||||||||||||||||||||||||||
| Project |
Activity
|
| Branch Review |
backport/2565/stable33
|
| Run status |
|
| Run duration | 04m 02s |
| Commit |
|
| Committer | backportbot[bot] |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
 |
0
|
 |
0
|
 |
1
|
 |
0
|
 |
9
|
| View all changes introduced in this branch ↗︎ | |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of PR #2565