Merged
Conversation
alperozturk96
added
3. to review
performance 🚀
alperozturk96
force-pushed
the
fix/file-export
branch
from
8343d42 to
f36ec9d
Compare
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
alperozturk96
force-pushed
the
fix/file-export
branch
from
5ade9c1 to
4ec2df4
Compare
|
APK file: https://www.kaminsky.me/nc-dev/android-artifacts/16707.apk |
|
blue-Light-Screenshot test failed, but no output was generated. Maybe a preliminary stage failed. |
tobiasKaminsky
approved these changes
Mar 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
The worker was crashing when users tried to export too many files. In such cases, users would see an empty notification.
FileDownloadWorkerwas being triggered for each export attempt instead of handling all exports within a single worker.Changes
Introduced a reusable
WorkerFilesPayloadto eliminate worker data limits.Switched to a coroutine-based worker that downloads all files within a single
FilesExportWorker.Now only one notification is shown at the end of the worker process.