Skip to content

fix(file-import): share from other apps#16736

Merged
alperozturk96 merged 2 commits intomasterfrom
fix/share-multiple-files-via-client
Mar 26, 2026
Merged

fix(file-import): share from other apps#16736
alperozturk96 merged 2 commits intomasterfrom
fix/share-multiple-files-via-client

Conversation

@alperozturk96
Copy link
Copy Markdown
Collaborator

Issue

Importing files from other apps causing:

E  Not enough permissions to read source file content://org.fossify.filemanager.provider/external_files/storage/emulated/0/Download/test_images/image_63.JPG
java.lang.SecurityException: Permission Denial: reading androidx.core.content.FileProvider uri content://org.fossify.filemanager.provider/external_files/storage/emulated/0/Download/test_images/image_63.JPG from pid=7195, uid=10244 requires the provider be exported, or grantUriPermission()
                                                                                                        at android.os.Parcel.createExceptionOrNull(Parcel.java:3340)
                                                                                                        at android.os.Parcel.createException(Parcel.java:3324)
                                                                                                        at android.os.Parcel.readException(Parcel.java:3307)
                                                                                                        at android.database.DatabaseUtils.readExceptionFromParcel(DatabaseUtils.java:201)

Changes

Fixes the issue
Converts Java to Kotlin
Uses Coroutines instead of deprecated AsyncTask

Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
@github-actions
Copy link
Copy Markdown

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/16736.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

@github-actions
Copy link
Copy Markdown

Codacy

SpotBugs

CategoryBaseNew
Bad practice3939
Correctness7470
Dodgy code236236
Experimental11
Internationalization77
Malicious code vulnerability22
Multithreaded correctness3434
Performance4342
Security1817
Total454448

@github-actions
Copy link
Copy Markdown

blue-Light-Screenshot test failed, but no output was generated. Maybe a preliminary stage failed.

@alperozturk96 alperozturk96 merged commit e7e15b6 into master Mar 26, 2026
17 of 22 checks passed
@alperozturk96 alperozturk96 deleted the fix/share-multiple-files-via-client branch March 26, 2026 09:40
@alperozturk96 alperozturk96 added the performance 🚀 Performance improvement opportunities (non-crash related) label Mar 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review performance 🚀 Performance improvement opportunities (non-crash related)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants