feat(sync): download folder including all nested files

[alperozturk96]

Issue: #269

Any feedback regarding icons and wording?

@AndyScherzinger @kra-mo

[github-actions]

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/16744.apk



To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

[AndyScherzinger]

Icon looks okay to me, didn't find any thats would be a better option match, maybe @kra-mo has an idea.

Other than that for me the question would be the position in the list. I would put it below the sync item, so it is close in terms of feature. It does however raise the question why there is is sync and sync all.

[alperozturk96]

Icon looks okay to me, didn't find any thats would be a better option match, maybe @kra-mo has an idea.

Other than that for me the question would be the position in the list. I would put it below the sync item, so it is close in terms of feature. It does however raise the question why there is is sync and sync all.

Sync -> Downloads first hierarchy
Sync all -> Downloads entire folder hiearchy

[120e314-git]

Icon looks okay to me, didn't find any thats would be a better option match, maybe @kra-mo has an idea.
Other than that for me the question would be the position in the list. I would put it below the sync item, so it is close in terms of feature. It does however raise the question why there is is sync and sync all.

Sync -> Downloads first hierarchy Sync all -> Downloads entire folder hiearchy

Hey, maybe a kinda stupid question: Why you dont name it like "Download entire Folder". It's more specific and the user would know immediatly what this funcion does.
Also a small, maybe offtopic, question: Wasn't there already a function to download folder earlier? Why was it removed then?

[claywd]

Icon looks okay to me, didn't find any thats would be a better option match, maybe @kra-mo has an idea.
Other than that for me the question would be the position in the list. I would put it below the sync item, so it is close in terms of feature. It does however raise the question why there is is sync and sync all.

Sync -> Downloads first hierarchy Sync all -> Downloads entire folder hiearchy

Hey, maybe a kinda stupid question: Why you dont name it like "Download entire Folder". It's more specific and the user would know immediatly what this funcion does. Also a small, maybe offtopic, question: Wasn't there already a function to download folder earlier? Why was it removed then?

This could also be a follow up. Personally, I think sync and sync all (which is current nomenclature) makes the most since. Or even "sync recursively" since the sync all options is what is new to the ecosystem here.

[github-actions]

APK file: https://github.com/nextcloud/android/actions/runs/23890822616/artifacts/6237519331
To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.
(please click on link to get QR code displayed)

[github-actions]

Codacy

SpotBugs

Category	Base	New
Bad practice	37	37
Correctness	69	69
Dodgy code	230	229
Experimental	1	1
Internationalization	7	7
Malicious code vulnerability	2	2
Multithreaded correctness	34	34
Performance	42	42
Security	16	16
Total	438	437

[github-actions]

APK file: https://github.com/nextcloud/android/actions/runs/23891605103/artifacts/6237841547
To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.
(please click on link to get QR code displayed)

[github-actions]

blue-Light-Screenshot test failed, but no output was generated. Maybe a preliminary stage failed.