fix: show the "Set as default mail app" button only if possible to register the protocol handler - #13416
Open
madbob wants to merge 1 commit into
Open
fix: show the "Set as default mail app" button only if possible to register the protocol handler#13416madbob wants to merge 1 commit into
madbob wants to merge 1 commit into
Conversation
kesselb
reviewed
Aug 3, 2026
| :open.sync="showSettings"> | ||
| <NcAppSettingsSection id="general" :name="t('mail', 'General')"> | ||
| <NcButton | ||
| v-if="canRegisterProtocolHandler" |
Contributor
There was a problem hiding this comment.
I'd say we should also have a v-else block explaining why it's not possible to register the app as handler.
Collaborator
Author
There was a problem hiding this comment.
I've added an extra check about the protocol, which is the only case that can be tested.
If window.navigator.registerProtocolHandler is not defined it may also depend by the browser not supporting the registration of apps, ungranted permissions, blocking extensions, or any other untestable condition.
Please check my copy about the warning notices: you know I'm very bad writer!
…gister the protocol handler Signed-off-by: Roberto Guido <info@madbob.org>
madbob
force-pushed
the
register_protocol_is_possibile
branch
from
August 12, 2026 13:52
ee7c7cb to
03dcd95
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Minor fix: in the Settings panel, display the "Set as default mail app" button only if
registerProtocolHandleris available.Not all browsers support this, and it is required a secure context (HTTPS) to actually register a protocol handler.