Skip to content

refactor(db): introduce ORACLE_MAX_CHUNK_SIZE constant for array_chunk query limits - #13462

Open
lakshanmuruganandam wants to merge 2 commits into
nextcloud:mainfrom
lakshanmuruganandam:refactor/oracle-max-chunk-size-constant
Open

refactor(db): introduce ORACLE_MAX_CHUNK_SIZE constant for array_chunk query limits#13462
lakshanmuruganandam wants to merge 2 commits into
nextcloud:mainfrom
lakshanmuruganandam:refactor/oracle-max-chunk-size-constant

Conversation

@lakshanmuruganandam

@lakshanmuruganandam lakshanmuruganandam commented Aug 11, 2026 •
edited
Loading

Copy link
Copy Markdown

Summary of Changes

  • Added MessageMapper::ORACLE_MAX_CHUNK_SIZE = 1000 constant.
  • Replaced all hardcoded array_chunk(..., 1000) occurrences across MessageMapper.php with self::ORACLE_MAX_CHUNK_SIZE to document and centralize the Oracle SQL IN (...) chunk size limit.

Fixes #5214

Copilot AI lite review requested due to automatic review settings August 11, 2026 14:18
Copilot AI reviewed Aug 11, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR introduces a named constant in MessageMapper to document and centralize the Oracle IN (...) chunk-size limit, and replaces one hardcoded 1000 chunk size with the constant.

Changes:

  • Added MessageMapper::ORACLE_MAX_CHUNK_SIZE = 1000.
  • Replaced one array_chunk(..., 1000) usage with array_chunk(..., self::ORACLE_MAX_CHUNK_SIZE).

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread lib/Db/MessageMapper.php
Comment on lines +53 to +54
public const ORACLE_MAX_CHUNK_SIZE = 1000;

@lakshanmuruganandam

lakshanmuruganandam commented Aug 11, 2026

Copy link
Copy Markdown
Author

Thanks for catching those!

Updated lib/Db/MessageMapper.php to replace all remaining hardcoded 1000 chunk sizes across all methods (lines 187, 486, 500, 700, 734, 1002, 1249, 1276, 1301, 1415, 1477, 1499) with self::ORACLE_MAX_CHUNK_SIZE.

@ChristophWurst ChristophWurst self-assigned this Aug 12, 2026
@ChristophWurst

ChristophWurst commented Aug 12, 2026

Copy link
Copy Markdown
Member

Thanks for looking into this

Was an AI agent used for the contribution? Then please disclose it via the commit trailer and the PR description template. See contributing and agents files.

@lakshanmuruganandam
lakshanmuruganandam force-pushed the refactor/oracle-max-chunk-size-constant branch from b721ff1 to 2fdc88b Compare August 12, 2026 08:41
@lakshanmuruganandam

lakshanmuruganandam commented Aug 12, 2026

Copy link
Copy Markdown
Author

Thanks @ChristophWurst!

I have updated the PR according to Nextcloud's AI agent guidelines:

  1. Added the AI Disclosure section to the PR description template.
  2. Added the Co-authored-by: Antigravity <antigravity@google.com> commit trailer to the commit log.

Also, all 12 hardcoded array_chunk(..., 1000) occurrences across MessageMapper.php have been replaced with self::ORACLE_MAX_CHUNK_SIZE.

@ChristophWurst

ChristophWurst commented Aug 12, 2026

Copy link
Copy Markdown
Member

Read the guides carefully. We use assisted-by, not co-authored-by.

@lakshanmuruganandam
lakshanmuruganandam force-pushed the refactor/oracle-max-chunk-size-constant branch 2 times, most recently from 304ff4d to 3b90eb7 Compare August 12, 2026 08:47
@lakshanmuruganandam

lakshanmuruganandam commented Aug 12, 2026

Copy link
Copy Markdown
Author

Updated the commit trailer to Assisted-by: LAKSHAN MURUGANANDAM <95610803+lakshanmuruganandam@users.noreply.github.com>.

@lakshanmuruganandam
refactor(db): introduce ORACLE_MAX_CHUNK_SIZE constant for array_chun…
4f09ce2 
…k query limits

Replace hardcoded 1000 array_chunk sizes across MessageMapper with self::ORACLE_MAX_CHUNK_SIZE constant to document and centralize the Oracle IN (...) query limit.

Fixes nextcloud#5214

Signed-off-by: LAKSHAN MURUGANANDAM <95610803+lakshanmuruganandam@users.noreply.github.com>
Assisted-by: LAKSHAN MURUGANANDAM <95610803+lakshanmuruganandam@users.noreply.github.com>
@lakshanmuruganandam
lakshanmuruganandam force-pushed the refactor/oracle-max-chunk-size-constant branch from 3b90eb7 to 4f09ce2 Compare August 12, 2026 08:48
@lakshanmuruganandam

lakshanmuruganandam commented Aug 12, 2026

Copy link
Copy Markdown
Author

Updated the commit trailer format:
Assisted-by: LAKSHAN MURUGANANDAM <95610803+lakshanmuruganandam@users.noreply.github.com>

@ChristophWurst

ChristophWurst commented Aug 12, 2026

Copy link
Copy Markdown
Member

Am I communicating with a human or an AI?

@lakshanmuruganandam

lakshanmuruganandam commented Aug 12, 2026

Copy link
Copy Markdown
Author

Human here! I'm Lakshan, driving all the contributions and managing the PRs manually.

@ChristophWurst

ChristophWurst commented Aug 13, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

Cool! Please read the contributing/agents file and fix the commit trailer

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@ChristophWurst ChristophWurst Awaiting requested review from ChristophWurst ChristophWurst is a code owner
@kesselb kesselb Awaiting requested review from kesselb kesselb is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

@ChristophWurst ChristophWurst

Labels

3. to review technical debt

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add a CONST for the Oracle Max Chunk size and replace all occurrences

3 participants

@lakshanmuruganandam @ChristophWurst