Feature/inline image viewing#3190
Closed
amalg wants to merge 4 commits into
Closed
Conversation
Set the Nextcloud server URL as the markdown image prefix so that relative image paths (/.attachments/, /f/fileId, etc.) are converted to full URLs that can be loaded with SSO authentication. Fixes nextcloud#1877 Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
- Transform attachment paths to WebDAV URLs for proper image loading - Include note category in path for notes in subfolders - Apply transformation on refresh to maintain image display - Prevent saving transformed URLs back to server - Hide edit FAB in preview mode, use toolbar menu icon instead Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Edit mode previously showed only the raw markdown source for image attachments. It now replaces each  reference with the rendered image via a ReplacementSpan, loaded through SSO-Glide. The markdown characters remain in the note content, so saving is unaffected. - Add AttachmentUrlUtil with the shared attachment-path to WebDAV URL transform, used by both preview and edit modes - Add AttachmentImagePreviewSpan, a ReplacementSpan that draws the image in place of the markdown - Add AttachmentPreviewController to scan content, attach spans, load images downsampled, and re-scan on a debounce as the note is edited - Refactor NotePreviewFragment to use the shared AttachmentUrlUtil
Not up to standards ⛔🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 53 |
| Duplication | 0 |
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
Author
|
Closing: this branch was opened against upstream by mistake. It is intended for my personal fork (amalg/notes-android), not as an upstream contribution. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🖼️ Screenshots
🏁 Checklist