Open
Conversation
Signed-off-by: Holger Hees <holger.hees@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As nextcloud 33 support php 8.5, notes should support it too.
Current situation is, if I run nextcloud 33 with php 8.5, the latest notes version is 3.5.1, which is totally wrong.
The reason is that version 3.5.1 has a '*' as a php version string. Thats interpreted as version 3.5.1 is supporting all php versions. But version 3.5.1 is not running with nextcloud 33.
So the solution is to change the supported php version to match the one in latest nextcloud.