Allow configuring the User-Agent sent to Nextcloud - #723
Conversation
Some deployments front Nextcloud with proxies/WAFs that filter requests based on User-Agent, so the push daemon needs a way to send a custom one for the requests it makes to the Nextcloud instance (including credential verification). Adds a USER_AGENT env var / --user-agent flag, following the same config plumbing as ALLOW_SELF_SIGNED. Signed-off-by: Matthias Sauer <sauerm@strato.de>
fbecb1f to
7a12c6f
Compare
|
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |
This PR contains the following updates: | Package | Update | Change | Pending | |---|---|---|---| | [nextcloud/notify_push](https://github.com/nextcloud/notify_push) | patch | `v1.3.3` → `v1.3.4` | `v1.3.5` | --- ### Release Notes <details> <summary>nextcloud/notify_push (nextcloud/notify_push)</summary> ### [`v1.3.4`](https://github.com/nextcloud/notify_push/releases/tag/v1.3.4): 1.3.4 [Compare Source](nextcloud/notify_push@v1.3.3...v1.3.4) #### What's Changed - fix: automatically fall back to ipv4 if ipv6 is disabled an no bind address is specified by [@​icewind1991](https://github.com/icewind1991) in [#​710](nextcloud/notify_push#710) - Suggest optional security hardening in systemd service by [@​JustArchi](https://github.com/JustArchi) in [#​704](nextcloud/notify_push#704) - fix: add missing prefix to log as debug by [@​solracsf](https://github.com/solracsf) in [#​712](nextcloud/notify_push#712) - fix: migrate commands to OC\Core\Command\Base class by [@​Antreesy](https://github.com/Antreesy) in [#​708](nextcloud/notify_push#708) - Allow configuring the User-Agent sent to Nextcloud by [@​matsaur](https://github.com/matsaur) in [#​723](nextcloud/notify_push#723) - Quote paths when invoking notify\_push binary by [@​kesselb](https://github.com/kesselb) in [#​722](nextcloud/notify_push#722) - MSRV has been increased to 1.94 #### New Contributors - [@​solracsf](https://github.com/solracsf) made their first contribution in [#​712](nextcloud/notify_push#712) - [@​Antreesy](https://github.com/Antreesy) made their first contribution in [#​708](nextcloud/notify_push#708) - [@​rizlas](https://github.com/rizlas) made their first contribution in [#​695](nextcloud/notify_push#695) - [@​matsaur](https://github.com/matsaur) made their first contribution in [#​723](nextcloud/notify_push#723) - [@​kesselb](https://github.com/kesselb) made their first contribution in [#​722](nextcloud/notify_push#722) **Full Changelog**: <nextcloud/notify_push@v1.3.3...v1.3.4> </details> --- ### Configuration 📅 **Schedule**: (UTC) - Branch creation - At any time (no schedule defined) - Automerge - At any time (no schedule defined) 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0My4yNjAuMCIsInVwZGF0ZWRJblZlciI6IjQzLjI2MC4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6W119--> Reviewed-on: https://git.walbeck.it/walbeck-it/docker-nextcloud-notify-push/pulls/228
Some deployments front Nextcloud with proxies/WAFs that filter requests based on User-Agent, so the push daemon needs a way to send a custom one for the requests it makes to the Nextcloud instance (including credential verification). Adds a USER_AGENT env var / --user-agent flag, following the same config plumbing as ALLOW_SELF_SIGNED.
🤖 AI (if applicable)