Skip to content

refactor(Template): clarify TemplateLayout naming, comments, and docblocks#61051

Draft
joshtrichards wants to merge 3 commits into
masterfrom
jtr/refactor-TemplateLayout
Draft

refactor(Template): clarify TemplateLayout naming, comments, and docblocks#61051
joshtrichards wants to merge 3 commits into
masterfrom
jtr/refactor-TemplateLayout

Conversation

@joshtrichards
Copy link
Copy Markdown
Member

  • Resolves: #

Summary

I'm working on some other changes in this class, but figured I'd submit these easier to review changes first.

This PR aims to improve readability of OC\TemplateLayout by clarifying naming, comments, and docblocks. It also adds basic unit test coverage.

Specific changes:

  • Adds class docblock
  • Adds key function docblocks
  • Some minor code reformatting (lines 106-126)
  • Renames variables for improved clarity
  • Replaces vague comments
  • Adds clarifying comments in key spots
  • Makes locator properties private

TODO

  • ...

Checklist

AI (if applicable)

  • The content of this PR was partly or fully generated using AI

Signed-off-by: Josh <josh.t.richards@gmail.com>
Signed-off-by: Josh <josh.t.richards@gmail.com>
Also make locator properties private instead of public and code reformatting.

Signed-off-by: Josh <josh.t.richards@gmail.com>
@joshtrichards joshtrichards added this to the Nextcloud 35 milestone Jun 6, 2026
@joshtrichards joshtrichards added 2. developing Work in progress technical debt 🧱 🤔🚀 feature: templates ♻️ refactor Refactor code (not a bug fix, not a feature just refactoring) labels Jun 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

2. developing Work in progress feature: templates ♻️ refactor Refactor code (not a bug fix, not a feature just refactoring) technical debt 🧱 🤔🚀

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant