fix(taskprocessing): claim tasks atomically so parallel workers don't duplicate#61053
Open
bygadd wants to merge 2 commits into
Open
fix(taskprocessing): claim tasks atomically so parallel workers don't duplicate#61053bygadd wants to merge 2 commits into
bygadd wants to merge 2 commits into
Conversation
Signed-off-by: bygadd <bygadd@gmail.com>
Signed-off-by: bygadd <bygadd@gmail.com>
bygadd
requested review from
ArtificialOwl,
artonge,
leftybournes and
salmart-dev
and removed request for
a team
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #61052
occ taskprocessing:workerclaimed tasks non-atomically, so multiple parallel workers processed the same task (both concurrently and sequentially), wasting worker capacity and multiplying provider/LLM calls.This PR:
WorkerCommand::processNextTask()now callslockTask()aftergetNextScheduledTask()and skips + re-fetches (via an ignore list) when the lock fails — mirroringTaskProcessingApiController.TaskMapper::lockTask()now guards withstatus = STATUS_SCHEDULEDinstead ofstatus != STATUS_RUNNING, so an already-completed task cannot be re-claimed.Verified on 33.0.5 with 8 concurrent workers: every task processed exactly once (0 duplicates), vs 4× before.
Signed-off-by: bygadd bygadd@gmail.com