fix(Sharing): Remove faulty check if required properties have a defaut value#62455
Open
provokateurin wants to merge 1 commit into
Open
fix(Sharing): Remove faulty check if required properties have a defaut value#62455provokateurin wants to merge 1 commit into
provokateurin wants to merge 1 commit into
Conversation
…lt value Signed-off-by: provokateurin <kate@provokateurin.de>
CarlSchwan
approved these changes
Jul 23, 2026
skjnldsv
approved these changes
Jul 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#51803
Because both are computed, the result depends on the server configuration. If there is a logic mistake in either of them, we might not detect it and admins with a specific config would be affected. It's much better to accidentally not provide a default value than to brick sharing (and possibly more).