feat(federation): implement minimal federation user backend#62471
Open
leftybournes wants to merge 1 commit into
Open
feat(federation): implement minimal federation user backend#62471leftybournes wants to merge 1 commit into
leftybournes wants to merge 1 commit into
Conversation
Signed-off-by: Kent Delante <kent@delante.me>
leftybournes
added
enhancement
3. to review
leftybournes
requested review from
Altahrim,
come-nc,
provokateurin and
salmart-dev
and removed request for
a team
July 24, 2026 07:22
Member
Author
|
Tests are related. I'm looking into it. |
CarlSchwan
requested changes
Jul 24, 2026
| } | ||
|
|
||
| #[\Override] | ||
| public function hasUserListings() { |
Member
There was a problem hiding this comment.
need return types for every of these methods and parameter types for the methods where it is defined in IUserBackend/UserInterface
| } | ||
|
|
||
| #[\Override] | ||
| public function getDisplayNames($search = '', $limit = null, $offset = null) { |
Member
There was a problem hiding this comment.
It's better to leave the default implementation from ABackend than returning an empty array
And ideally a proper implementation of this method is implemented based on a new method ICloudIdManager::resolveCloudIds(array $ids);
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This adds a minimal user backend for federation that can continue to be built upon.
This was inspired by and fixes an issue where the "Deleted by" column in the trashbin is shown as "Unknown" if a file shared externally was deleted by a remote user. The "Deleted by" column will now correctly show the federated user as the deleter (e.g. bob@example.com)
Checklist
3. to review, feature component)stable32)AI (if applicable)