fix: Use PHP_AUTH_PW for strict password confirmation#62477
Open
SystemKeeper wants to merge 2 commits into
Open
fix: Use PHP_AUTH_PW for strict password confirmation#62477SystemKeeper wants to merge 2 commits into
SystemKeeper wants to merge 2 commits into
Conversation
Signed-off-by: Marcel Müller <marcel-mueller@gmx.de>
Signed-off-by: Marcel Müller <marcel-mueller@gmx.de>
SystemKeeper
force-pushed
the
fix/62362/password-confirmation-php-auth-pw
branch
from
July 24, 2026 11:54
38fb22e to
eebb3a2
Compare
SystemKeeper
marked this pull request as ready for review
July 24, 2026 12:37
SystemKeeper
requested review from
Altahrim,
leftybournes,
provokateurin and
salmart-dev
and removed request for
a team
July 24, 2026 12:37
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
We already make sure that
AUTHORIZATIONheaders are copied toPHP_AUTH_USERandPHP_AUTH_PW, so these should work in all cases.Please check if there's any reason to access the raw authorization header in that method, in that case we could use the
PHP_AUTH_*ones as fallback.Checklist
3. to review, feature component)stable32)AI (if applicable)