Skip to content

fix: Use PHP_AUTH_PW for strict password confirmation#62477

Open
SystemKeeper wants to merge 2 commits into
masterfrom
fix/62362/password-confirmation-php-auth-pw
Open

fix: Use PHP_AUTH_PW for strict password confirmation#62477
SystemKeeper wants to merge 2 commits into
masterfrom
fix/62362/password-confirmation-php-auth-pw

Conversation

@SystemKeeper

@SystemKeeper SystemKeeper commented Jul 24, 2026

Copy link
Copy Markdown
Contributor

Summary

We already make sure that AUTHORIZATION headers are copied to PHP_AUTH_USER and PHP_AUTH_PW, so these should work in all cases.
Please check if there's any reason to access the raw authorization header in that method, in that case we could use the PHP_AUTH_* ones as fallback.

Checklist

AI (if applicable)

  • The content of this PR was partly or fully generated using AI

@SystemKeeper SystemKeeper self-assigned this Jul 24, 2026
Signed-off-by: Marcel Müller <marcel-mueller@gmx.de>
Signed-off-by: Marcel Müller <marcel-mueller@gmx.de>
@SystemKeeper
SystemKeeper force-pushed the fix/62362/password-confirmation-php-auth-pw branch from 38fb22e to eebb3a2 Compare July 24, 2026 11:54
@SystemKeeper SystemKeeper changed the title Fix/62362/password confirmation php auth pw fix: Use PHP_AUTH_PW for strict password confirmation Jul 24, 2026
@SystemKeeper SystemKeeper added the 3. to review Waiting for reviews label Jul 24, 2026
@SystemKeeper
SystemKeeper marked this pull request as ready for review July 24, 2026 12:37
@SystemKeeper
SystemKeeper requested a review from a team as a code owner July 24, 2026 12:37
@SystemKeeper
SystemKeeper requested review from Altahrim, leftybournes, provokateurin and salmart-dev and removed request for a team July 24, 2026 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews 34-feedback bug feature: authentication php Pull requests that update Php code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Creating and deleting App Tokens runs into error

1 participant