fix(files_sharing): roll back shared storage locks on owner lock failure#62484
Draft
joshtrichards wants to merge 3 commits into
Draft
fix(files_sharing): roll back shared storage locks on owner lock failure#62484joshtrichards wants to merge 3 commits into
joshtrichards wants to merge 3 commits into
Conversation
Assisted-by: Copilot:GPT-5 Signed-off-by: Josh <josh.t.richards@gmail.com>
Assisted-by: Copilot:GPT-5.6 Signed-off-by: Josh <josh.t.richards@gmail.com>
joshtrichards
added
bug
2. developing
Assisted-by: Copilot:GPT-5.6 Signed-off-by: Josh <josh.t.richards@gmail.com>
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
More locking behavior cleanup...
When locking a shared-storage root, failure to lock the owner parent previously left the target lock held.
This change rolls back the target lock while preserving the original exception if rollback fails. Unlocking now follows reverse acquisition order and still attempts target cleanup if the owner-side unlock fails. Tests cover rollback, cleanup ordering, and rollback failure behavior.
TODO
Checklist
3. to review, feature component)stable32)AI (if applicable)