nmc/5811-file-setting-close-button-not-working-in-mobile#472
Merged
memurats merged 1 commit intoMay 8, 2026
Merged
Conversation
…modal The modal close button was unresponsive to exact taps on mobile (Android & iOS). Root cause: the scrollable `.modal-container__content` (overflow-y: auto) overlaps the close button's touch area. The button is positioned at top/right 0.5rem (~8px) and is ~44px tall, while the content starts at 1.5rem (24px) padding — meaning the scroll region covers the button from 24px to 52px, including its center. On mobile, the browser's scroll gesture handler captures touches that start inside the overflow-y:auto region before z-index hit-testing reaches the button, making exact taps on the button appear broken while taps outside the scroll region (the top edge of the button, within the padding area) still worked. Fix: add `touch-action: manipulation` to `.modal-container__close`, which disables scroll-gesture detection on the element so taps are delivered directly to the button.
memurats
approved these changes
May 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.