fix: point root types to published declaration#4347
Conversation
|
@Fernando-droidx is attempting to deploy a commit to the Nitro Team on Vercel. A member of the Team first needs to authorize it. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe package.json ChangesTypes Declaration Fix
🎯 1 (Trivial) | ⏱️ ~2 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary
typesfield at the declaration generated beside the root runtime exportmoduleResolution: "node"Fixes #4346.
Validation
pnpm typecheckgit diff --checkdist/runtime/nitro.d.mtsis generated and included by the packagefileslistnitro@3.0.260610-beta: TypeScript follows./lib/index.d.mts, which is absent from the tarballpnpm buildgenerated the runtime declarations but did not complete on local Node.js 22.13.1 becausenode ./scripts/gen-presets.tsdoes not support direct.tsexecution on that Node version.